third_party/WebKit/LayoutTests/media/track/track-addtrack-kind.html - Issue 1873093003: Convert track tests from video-test.js to testharness.js based

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/media/track/track-addtrack-kind.html

Issue 1873093003: Convert track tests from video-test.js to testharness.js based (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/media/track/track-add-track.html ('K') | « third_party/WebKit/LayoutTests/media/track/track-add-track-expected.txt ('k') | third_party/WebKit/LayoutTests/media/track/track-addtrack-kind-expected.txt » ('j') | third_party/WebKit/LayoutTests/media/track/track-change-event.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <title>Tests that the addTextTrack() only accepts known "kind" values.</title>

3 <head>	3 <script src="../../resources/testharness.js"></script>

4 <meta http-equiv="Content-Type" content="text/html; charset=utf-8" />	4 <script src="../../resources/testharnessreport.js"></script>

	5 <script>

	6 var video;
	philipj_slow 2016/04/11 12:34:00 Move this and the below into the test. Move this and the below into the test. Srirama 2016/04/11 13:34:24 Done. Show quoted text On 2016/04/11 12:34:00, philipj wrote: > Move this and the below into the test. Done.
	7 var trackCount = 0;

5	8

6 <script src=../media-file.js></script>	9 function addTrack(type) {

7 <!-- TODO(philipj): Convert test to testharness.js. crbug.com/588956	10 video.addTextTrack(type);

8 (Please avoid writing new tests using video-test.js) -->	11 assert_equals(video.textTracks.length, ++trackCount);

9 <script src=../video-test.js></script>	12 }

10 <script>

11	13

12 var trackCount = 0;	14 test(function() {

	15 video = document.createElement("video");

	16 assert_equals(video.textTracks.length, 0);

	17 assert_throws(new TypeError(), function() { video.addTextTrack("kaptions"); });

	18 assert_equals(video.textTracks.length, 0);

13	19

14 function addTrack(type)	20 addTrack("subtitles");

15 {	21 addTrack("captions");

16 run("video.addTextTrack('" + type + "')");	22 addTrack("descriptions");

17 testExpected("video.textTracks.length", ++trackCount);	23 addTrack("chapters");

18 }	24 addTrack("metadata");

19	25 });

20 function start()	26 </script>

21 {

22 findMediaElement();

23

24 consoleWrite("<em>++ Test invalid 'kind'.</em>");

25 testExpected("video.textTracks.length", 0);

26 testException("video.addTextTrack('kaptions')", '"TypeError: Fai led to execute \'addTextTrack\' on \'HTMLMediaElement\': parameter 1 (\'kaptions \') is not a valid enum value."');

27 testExpected("video.textTracks.length", 0);

28 consoleWrite("");

29

30 consoleWrite("<em>++ Test all valid 'kind' keywords.</em>");

31 addTrack("subtitles");

32 addTrack("captions");

33 addTrack("descriptions");

34 addTrack("chapters");

35 addTrack("metadata");

36

37 consoleWrite("");

38 endTest();

39 }

40

41 </script>

42 </head>

43 <body onload="start()">

44 <p>Tests that the addTextTrack() only accepts known 'kind' values.</p>

45 <video>

46 </video>

47 </body>

48 </html>

OLD	NEW