Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1873073002:
Record domains where Reader Mode is prompted or opened (Closed)
DescriptionRecord domains where Reader Mode is prompted or opened
Use RAPPOR to anonymously record the domains in two cases:
1. Reader Mode panel is prompted
In AdaBoost heuristic, this means the page is distillable.
2. Reader Mode panel is opened by the user
BUG=602134
Committed: https://crrev.com/8dd3c54659c4e99b4ba31254fed0094defd4ffd1
Cr-Commit-Position: refs/heads/master@{#387831}
Patch Set 1 : #Patch Set 2 : make sure native lib is loaded #
Messages
Total messages: 28 (16 generated)
Description was changed from ========== Record Reader Mode Panel usage in RAPPOR BUG= ========== to ========== Record domains where Reader Mode is prompted or opened Use RAPPOR to anonymously record the domains in two cases: 1. Reader Mode panel is prompted In AdaBoost heuristic, this means the page is distillable. 2. Reader Mode panel is opened by the user BUG= ==========
Description was changed from ========== Record domains where Reader Mode is prompted or opened Use RAPPOR to anonymously record the domains in two cases: 1. Reader Mode panel is prompted In AdaBoost heuristic, this means the page is distillable. 2. Reader Mode panel is opened by the user BUG= ========== to ========== Record domains where Reader Mode is prompted or opened Use RAPPOR to anonymously record the domains in two cases: 1. Reader Mode panel is prompted In AdaBoost heuristic, this means the page is distillable. 2. Reader Mode panel is opened by the user BUG= ==========
Description was changed from ========== Record domains where Reader Mode is prompted or opened Use RAPPOR to anonymously record the domains in two cases: 1. Reader Mode panel is prompted In AdaBoost heuristic, this means the page is distillable. 2. Reader Mode panel is opened by the user BUG= ========== to ========== Record domains where Reader Mode is prompted or opened Use RAPPOR to anonymously record the domains in two cases: 1. Reader Mode panel is prompted In AdaBoost heuristic, this means the page is distillable. 2. Reader Mode panel is opened by the user BUG=602134 ==========
wychen@chromium.org changed reviewers: + mdjones@chromium.org
PTAL
Patchset #1 (id:1) has been deleted
Patchset #1 (id:20001) has been deleted
wychen@chromium.org changed reviewers: + jwd@chromium.org
jwd@, could you take a look at rappor.xml? Thanks!
lgtm
lgtm
The CQ bit was checked by wychen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1873073002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1873073002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by wychen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1873073002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1873073002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by wychen@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from mdjones@chromium.org, jwd@chromium.org Link to the patchset: https://codereview.chromium.org/1873073002/#ps60001 (title: "make sure native lib is loaded")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1873073002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1873073002/60001
Message was sent while issue was closed.
Description was changed from ========== Record domains where Reader Mode is prompted or opened Use RAPPOR to anonymously record the domains in two cases: 1. Reader Mode panel is prompted In AdaBoost heuristic, this means the page is distillable. 2. Reader Mode panel is opened by the user BUG=602134 ========== to ========== Record domains where Reader Mode is prompted or opened Use RAPPOR to anonymously record the domains in two cases: 1. Reader Mode panel is prompted In AdaBoost heuristic, this means the page is distillable. 2. Reader Mode panel is opened by the user BUG=602134 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Record domains where Reader Mode is prompted or opened Use RAPPOR to anonymously record the domains in two cases: 1. Reader Mode panel is prompted In AdaBoost heuristic, this means the page is distillable. 2. Reader Mode panel is opened by the user BUG=602134 ========== to ========== Record domains where Reader Mode is prompted or opened Use RAPPOR to anonymously record the domains in two cases: 1. Reader Mode panel is prompted In AdaBoost heuristic, this means the page is distillable. 2. Reader Mode panel is opened by the user BUG=602134 Committed: https://crrev.com/388989c6665e2e46749eead442ffc942562d6e7b Cr-Commit-Position: refs/heads/master@{#387830} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/388989c6665e2e46749eead442ffc942562d6e7b Cr-Commit-Position: refs/heads/master@{#387830}
Message was sent while issue was closed.
Description was changed from ========== Record domains where Reader Mode is prompted or opened Use RAPPOR to anonymously record the domains in two cases: 1. Reader Mode panel is prompted In AdaBoost heuristic, this means the page is distillable. 2. Reader Mode panel is opened by the user BUG=602134 Committed: https://crrev.com/388989c6665e2e46749eead442ffc942562d6e7b Cr-Commit-Position: refs/heads/master@{#387830} ========== to ========== Record domains where Reader Mode is prompted or opened Use RAPPOR to anonymously record the domains in two cases: 1. Reader Mode panel is prompted In AdaBoost heuristic, this means the page is distillable. 2. Reader Mode panel is opened by the user BUG=602134 Committed: https://crrev.com/8dd3c54659c4e99b4ba31254fed0094defd4ffd1 Cr-Commit-Position: refs/heads/master@{#387831} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/8dd3c54659c4e99b4ba31254fed0094defd4ffd1 Cr-Commit-Position: refs/heads/master@{#387831} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
