sync/api/attachments/fake_attachment_store_unittest.cc - Issue 187303006: Update sync API to support attachments.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/api/attachments/fake_attachment_store_unittest.cc

Issue 187303006: Update sync API to support attachments. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@attachmentapi

Patch Set: Rename GetAttachments to GetLocalAttachmentsForUpload. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sync/api/attachments/fake_attachment_store_unittest.cc

diff --git a/sync/api/attachments/fake_attachment_store_unittest.cc b/sync/api/attachments/fake_attachment_store_unittest.cc

index 797c3a6769b12e9f142b0efc578fe5bde2025d1f..e5606975075758fa8623d4539ea95d24f9be4a30 100644

--- a/sync/api/attachments/fake_attachment_store_unittest.cc

+++ b/sync/api/attachments/fake_attachment_store_unittest.cc

@@ -98,8 +98,8 @@ TEST_F(FakeAttachmentStoreTest, WriteReadRoundTrip) {

TEST_F(FakeAttachmentStoreTest, Read_NotFound) {

FakeAttachmentStore store(base::MessageLoopProxy::current());

scoped_refptr<base::RefCountedString> some_data(new base::RefCountedString);

- scoped_ptr<Attachment> some_attachment = Attachment::Create(some_data);

- AttachmentId some_id = some_attachment->GetId();

+ Attachment some_attachment = Attachment::Create(some_data);

+ AttachmentId some_id = some_attachment.GetId();

store.Read(some_id, read_callback);

ClearAndPumpLoop();

EXPECT_EQ(result, AttachmentStore::NOT_FOUND);

« no previous file with comments | « sync/api/attachments/fake_attachment_store.cc ('k') | sync/api/sync_change_processor.h » ('j') | no next file with comments »