Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3350)

Unified Diff: sync/internal_api/base_node.cc

Issue 187303006: Update sync API to support attachments. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@attachmentapi
Patch Set: Remove AttachmentServiceBase for reals. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sync/internal_api/base_node.cc
diff --git a/sync/internal_api/base_node.cc b/sync/internal_api/base_node.cc
index ac047686a5f1c0b9d83555230c3c12453a548f62..078839540e3e66c4a9bfeb5ccd32646fa86410b6 100644
--- a/sync/internal_api/base_node.cc
+++ b/sync/internal_api/base_node.cc
@@ -290,6 +290,13 @@ ModelType BaseNode::GetModelType() const {
return GetEntry()->GetModelType();
}
+const syncer::AttachmentIdList BaseNode::GetAttachmentIds() const {
+ // TODO(maniscalco): Once EntryKernel is capable of storing AttachmentIds,
+ // update this method to retrieve the list of AttachmentIds from read_node and
+ // pass it to CreateRemoteData (bug 348625).
+ return AttachmentIdList();
+}
+
void BaseNode::SetUnencryptedSpecifics(
const sync_pb::EntitySpecifics& specifics) {
ModelType type = GetModelTypeFromSpecifics(specifics);

Powered by Google App Engine
This is Rietveld 408576698