Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(825)

Unified Diff: chrome/browser/sync/glue/generic_change_processor_unittest.cc

Issue 187303006: Update sync API to support attachments. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@attachmentapi
Patch Set: Pull in upstream changes. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/glue/generic_change_processor_unittest.cc
diff --git a/chrome/browser/sync/glue/generic_change_processor_unittest.cc b/chrome/browser/sync/glue/generic_change_processor_unittest.cc
index 39d9aa89b0b705a4138229370d708053ad1311f7..516f99ce34924aa5dd320d62ad83529ed0acf622 100644
--- a/chrome/browser/sync/glue/generic_change_processor_unittest.cc
+++ b/chrome/browser/sync/glue/generic_change_processor_unittest.cc
@@ -9,6 +9,7 @@
#include "base/message_loop/message_loop.h"
#include "base/strings/stringprintf.h"
#include "components/sync_driver/data_type_error_handler_mock.h"
+#include "sync/api/attachments/fake_attachment_service.h"
#include "sync/api/fake_syncable_service.h"
#include "sync/api/sync_change.h"
#include "sync/api/sync_merge_result.h"
@@ -45,12 +46,12 @@ class SyncGenericChangeProcessorTest : public testing::Test {
test_user_share_.user_share());
}
test_user_share_.encryption_handler()->Init();
- change_processor_.reset(
- new GenericChangeProcessor(
- &data_type_error_handler_,
- syncable_service_ptr_factory_.GetWeakPtr(),
- merge_result_ptr_factory_.GetWeakPtr(),
- test_user_share_.user_share()));
+ change_processor_.reset(new GenericChangeProcessor(
+ &data_type_error_handler_,
+ syncable_service_ptr_factory_.GetWeakPtr(),
+ merge_result_ptr_factory_.GetWeakPtr(),
+ test_user_share_.user_share(),
+ syncer::FakeAttachmentService::CreateForTest()));
}
virtual void TearDown() OVERRIDE {
@@ -237,7 +238,9 @@ TEST_F(SyncGenericChangeProcessorTest, UpdatePasswords) {
}
}
+// TODO(maniscalco): Add test cases that verify GenericChangeProcessor calls the
+// right methods on its AttachmentService at the right times.
+
} // namespace
} // namespace browser_sync
-

Powered by Google App Engine
This is Rietveld 408576698