FlameChart: REGRESSION zoom doesn't work properly when time window has its initial values.

Source/devtools/front_end/FlameChart.js

 /**
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 407 matching lines @@
     this._overviewGrid = new WebInspector.OverviewGrid("flame-chart");
     this._overviewGrid.element.classList.add("fill");
     this._overviewCanvas = this._overviewContainer.createChild("canvas", "flame-chart-overview-canvas");
     this._overviewContainer.appendChild(this._overviewGrid.element);
     this._overviewCalculator = new WebInspector.FlameChart.OverviewCalculator();
     this._dataProvider = dataProvider;
 }
 
 WebInspector.FlameChart.OverviewPane.prototype = {
     /**
-     * @param {number} zoom
-     * @param {number} referencePoint
-     */
-    zoom: function(zoom, referencePoint)
-    {
-        this._overviewGrid.zoom(zoom, referencePoint);
-    },
-
-    /**
      * @param {number} windowStartTime
      * @param {number} windowEndTime
      */
     requestWindowTimes: function(windowStartTime, windowEndTime)
     {
         this._overviewGrid.setWindow(windowStartTime / this._dataProvider.totalTime(), windowEndTime / this._dataProvider.totalTime());
     },
 
     /**
      * @param {!number} timeLeft
@@ skipping 282 matching lines @@
         var data = this._dataProvider.entryData(this._highlightedEntryIndex);
         if (data)
             this.dispatchEventToListeners(WebInspector.FlameChart.Events.EntrySelected, data);
     },
 
     /**
      * @param {?MouseEvent} e
      */
     _onMouseWheel: function(e)
     {
-        var windowLeft = this._timeWindowLeft;
-        var windowRight = this._timeWindowRight;
+        var windowLeft = this._timeWindowLeft ? this._timeWindowLeft : this._dataProvider.zeroTime();

[pfeldman, 2014/03/05 05:33:50]

I think using -1 for default values is more appropriate. I do that in
TimelineView.js

+        var windowRight = this._timeWindowRight !== Infinity ? this._timeWindowRight : this._dataProvider.zeroTime() + this._dataProvider.totalTime();
+
         if (e.wheelDeltaY) {
             const mouseWheelZoomSpeed = 1 / 120;
             var zoom = Math.pow(1.2, -e.wheelDeltaY * mouseWheelZoomSpeed) - 1;
             var cursorTime = this._cursorTime(e.offsetX);
-            windowLeft += (this._timeWindowLeft - cursorTime) * zoom;
-            windowRight += (this._timeWindowRight - cursorTime) * zoom;
+            windowLeft += (windowLeft - cursorTime) * zoom;
+            windowRight += (windowRight - cursorTime) * zoom;
         } else {
             var shift = e.wheelDeltaX * this._pixelToTime;
             shift = Number.constrain(shift, this._zeroTime - windowLeft, this._totalTime + this._zeroTime - windowRight);
             windowLeft += shift;
             windowRight += shift;
         }
         windowLeft = Number.constrain(windowLeft, this._zeroTime, this._totalTime + this._zeroTime);
         windowRight = Number.constrain(windowRight, this._zeroTime, this._totalTime + this._zeroTime);
         this._timeRangeController.requestWindowTimes(windowLeft, windowRight);
     },
@@ skipping 316 matching lines @@
             this._timelineGrid.hideDividers();
         this.draw(this.element.clientWidth, this.element.clientHeight);
         this._calculator._updateBoundaries(this);
         this._timelineGrid.element.style.width = this.element.clientWidth;
         var offsets = this._dataProvider.dividerOffsets(this._calculator.minimumBoundary(), this._calculator.maximumBoundary());
         this._timelineGrid.updateDividers(this._calculator, offsets, true);
     },
 
     __proto__: WebInspector.View.prototype
 }