Issue 187303003: FlameChart: REGRESSION zoom doesn't work properly when time window has its initial values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 187303003: FlameChart: REGRESSION zoom doesn't work properly when time window has its initial values. (Closed)

Created:
6 years, 9 months ago by loislo

Modified:
6 years, 9 months ago

Reviewers:
pfeldman

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

FlameChart: REGRESSION zoom doesn't work properly when time window has its initial values. scenario: 1) record less than one second timeline 2) zoom in or zoom out BUG= R=pfeldman@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168434

Patch Set 1 #

Total comments: 1

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -13 lines)			Patch
	M	Source/devtools/front_end/FlameChart.js	View		2 chunks	+5 lines, -13 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

pfeldman

lgtm https://codereview.chromium.org/187303003/diff/1/Source/devtools/front_end/FlameChart.js File Source/devtools/front_end/FlameChart.js (right): https://codereview.chromium.org/187303003/diff/1/Source/devtools/front_end/FlameChart.js#newcode730 Source/devtools/front_end/FlameChart.js:730: var windowLeft = this._timeWindowLeft ? this._timeWindowLeft : this._dataProvider.zeroTime(); ...

6 years, 9 months ago (2014-03-05 05:33:49 UTC) #2

loislo

6 years, 9 months ago (2014-03-05 05:57:28 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r168434 (presubmit successful).

Expand Messages | Collapse Messages