Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 1873013002: [Media Router WebUI] Update arrow drop title text to be more descriptive. (Closed)

Created:
4 years, 8 months ago by apacible
Modified:
4 years, 7 months ago
Reviewers:
mark a. foltz
CC:
arv+watch_chromium.org, chromium-reviews, media-router+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Media Router WebUI] Update arrow drop title text to be more descriptive. Committed: https://crrev.com/20e088803eff3c44943cbbd69967ebde981c164e Cr-Commit-Position: refs/heads/master@{#387159}

Patch Set 1 : #

Patch Set 2 : Rebase. #

Patch Set 3 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -6 lines) Patch
M chrome/app/media_router_strings.grdp View 1 chunk +6 lines, -3 lines 0 comments Download
M chrome/browser/resources/media_router/elements/media_router_header/media_router_header.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/media_router/elements/media_router_header/media_router_header.js View 1 2 1 chunk +11 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/media_router/media_router_localized_strings_provider.cc View 1 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
apacible
PTAL, thanks!
4 years, 8 months ago (2016-04-11 14:58:02 UTC) #5
mark a. foltz
Looks like you'll need to rework this after landing the i18n_ optimization patch.
4 years, 8 months ago (2016-04-11 18:40:52 UTC) #6
apacible
Updated with the i18n changes.
4 years, 8 months ago (2016-04-12 16:21:15 UTC) #8
mark a. foltz
lgtm
4 years, 8 months ago (2016-04-13 19:38:56 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1873013002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1873013002/100001
4 years, 8 months ago (2016-04-13 23:50:50 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:100001)
4 years, 8 months ago (2016-04-13 23:57:25 UTC) #15
commit-bot: I haz the power
4 years, 8 months ago (2016-04-13 23:58:39 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/20e088803eff3c44943cbbd69967ebde981c164e
Cr-Commit-Position: refs/heads/master@{#387159}

Powered by Google App Engine
This is Rietveld 408576698