Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Issue 1873003002: Ensure all AssociatedURLLoader be cancelled before shutting down Blink. (Closed)

Created:
4 years, 8 months ago by leonhsl(Using Gerrit)
Modified:
4 years, 8 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ensure all AssociatedURLLoader be cancelled before shutting down Blink. ImageDownloaderImpl is using AssociatedURLLoader, all active AssociatedURLLoader must be cancelled before shutting down Blink. BUG=601737 Committed: https://crrev.com/d0173cb77f8a5771bc9f27b570149436707626f7 Cr-Commit-Position: refs/heads/master@{#386338}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1 line) Patch
M content/renderer/image_downloader/image_downloader_impl.h View 2 chunks +6 lines, -1 line 0 comments Download
M content/renderer/image_downloader/image_downloader_impl.cc View 3 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1873003002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1873003002/1
4 years, 8 months ago (2016-04-09 02:33:41 UTC) #2
leonhsl(Using Gerrit)
Hi, Jochen, would you PTAL at this? Thanks~ +tyoshino FYI
4 years, 8 months ago (2016-04-09 03:08:49 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-09 03:31:52 UTC) #6
jochen (gone - plz use gerrit)
lgtm
4 years, 8 months ago (2016-04-09 23:44:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1873003002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1873003002/1
4 years, 8 months ago (2016-04-11 04:41:20 UTC) #9
tyoshino (SeeGerritForStatus)
lgtm Thanks
4 years, 8 months ago (2016-04-11 05:38:08 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-11 05:41:46 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-11 05:43:33 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d0173cb77f8a5771bc9f27b570149436707626f7
Cr-Commit-Position: refs/heads/master@{#386338}

Powered by Google App Engine
This is Rietveld 408576698