Issue 1872953002: Fix stride bug for msan on I420Interpolate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1872953002: Fix stride bug for msan on I420Interpolate. (Closed)

Created:
4 years, 8 months ago by fbarchard1

Modified:
4 years, 8 months ago

Reviewers:
Diony Rosa

Base URL:
https://chromium.googlesource.com/libyuv/libyuv@master

Target Ref:
refs/heads/master

Project:
libyuv

Visibility:
Public.

Fix stride bug for msan on I420Interpolate. When using C version of I420Interpolate for msan, a 50% interpolation would cause stride to be cast to int, which could cause erroneous memory reads on 64 bit build. This CL makes the stride use ptrdiff_t for HalfRow_C BUG=libyuv:582 TESTED=try bots tests R=dhrosa@google.com Committed: https://chromium.googlesource.com/libyuv/libyuv/+/3c862e3d29f326902656c23b7e309f32adb7822c

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -8 lines)			Patch
M	README.chromium	View	1 chunk	+1 line, -1 line	0 comments	Download
M	include/libyuv/version.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	source/planar_functions.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	source/row_common.cc	View	4 chunks	+4 lines, -4 lines	0 comments	Download

Total messages: 4 (1 generated)

fbarchard1

4 years, 8 months ago (2016-04-08 22:58:58 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
3c862e3d29f326902656c23b7e309f32adb7822c (presubmit successful).