Add support for local services/characteristics/descriptors.

device/bluetooth/bluetooth_local_gatt_characteristic_bluez.cc

+// Copyright 2014 The Chromium Authors. All rights reserved.

[ortuno, 2016/04/14 17:42:35]

It's 2016!

[rkc, 2016/04/14 19:27:27]

That is true. A whole two years after 2014. Gosh, how does time fly!

+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "device/bluetooth/bluetooth_local_gatt_characteristic_bluez.h"
+
+#include "base/logging.h"
+#include "device/bluetooth/bluetooth_adapter_bluez.h"
+#include "device/bluetooth/bluetooth_gatt_descriptor_bluez.h"
+#include "device/bluetooth/bluetooth_local_gatt_service_bluez.h"
+#include "device/bluetooth/dbus/bluez_dbus_manager.h"
+#include "third_party/cros_system_api/dbus/service_constants.h"
+
+namespace bluez {
+
+BluetoothLocalGattCharacteristicBlueZ::BluetoothLocalGattCharacteristicBlueZ(
+    BluetoothLocalGattServiceBlueZ* service,
+    const dbus::ObjectPath& object_path)
+    : BluetoothGattCharacteristicBlueZ(service, object_path),
+      weak_ptr_factory_(this) {
+  VLOG(1) << "Creating local GATT characteristic with identifier: "
+          << GetIdentifier() << ", UUID: " << GetUUID().canonical_value();
+}
+
+BluetoothLocalGattCharacteristicBlueZ::
+    ~BluetoothLocalGattCharacteristicBlueZ() {}
+
+device::BluetoothUUID BluetoothLocalGattCharacteristicBlueZ::GetUUID() const {
+  NOTIMPLEMENTED();
+  return device::BluetoothUUID();
+}
+
+bool BluetoothLocalGattCharacteristicBlueZ::IsLocal() const {
+  return true;
+}
+
+const std::vector<uint8_t>& BluetoothLocalGattCharacteristicBlueZ::GetValue()
+    const {
+  NOTIMPLEMENTED();
+  static std::vector<uint8_t> temp;

[ortuno, 2016/04/14 17:42:35]

I thought we tried to avoid static because of the destruction overhead?

[rkc, 2016/04/14 19:27:27]

This class is not being constructed, let alone destructed.

[ortuno, 2016/04/14 21:17:38]

I'm thinking of this part of the style guide:
http://google.github.io/styleguide/cppguide.html#Static_and_Global_Variables

I might be reading it wrong, but I've been told in the past to avoid "static"
for variables.

[rkc, 2016/04/14 21:59:38]

This doesn't really violate the spirit of the rule in the style guide, since
this object will *never* get constructed.
Since you seem to feel quite strongly about this, I've changed this to be a
one-time initialized pointer which will never get freed, as the style guide
recommends.

+  return temp;
+}
+
+bool BluetoothLocalGattCharacteristicBlueZ::AddDescriptor(
+    device::BluetoothGattDescriptor* descriptor) {
+  NOTIMPLEMENTED();
+  return false;
+}
+
+device::BluetoothGattCharacteristic::Properties
+BluetoothLocalGattCharacteristicBlueZ::GetProperties() const {
+  NOTIMPLEMENTED();
+  return PROPERTY_NONE;
+}
+
+bool BluetoothLocalGattCharacteristicBlueZ::IsNotifying() const {
+  NOTIMPLEMENTED();
+  return false;
+}
+
+bool BluetoothLocalGattCharacteristicBlueZ::UpdateValue(
+    const std::vector<uint8_t>& value) {
+  NOTIMPLEMENTED();
+  return false;
+}
+
+void BluetoothLocalGattCharacteristicBlueZ::StartNotifySession(
+    const NotifySessionCallback& callback,
+    const ErrorCallback& error_callback) {
+  // Doesn't apply for a local characteristic.

[ortuno, 2016/04/14 17:42:35]

Please choose a pattern a follow it throughout:

1. Call NOTIMLPEMENTED with a comment on top and not run the callbacks. (This
what you do here.)
or 2. Log that the function is not supported on local objects and run callbacks.
See Register RemoteService.

[rkc, 2016/04/14 19:27:27]

I didn't change the code in the remote service Register method since that is
what was already there. Please see my comments about this being a refactor.

[ortuno, 2016/04/14 21:17:38]

nit: I understand the argument about the refactoring but this seems like new
code, no? All other code e.g. bluetooth_remote_gatt_characteristic_bluez.cc and
bluetooth_remote_gatt_service_bluez.cc call the error callbacks for methods
meant only for local objects. If you are planning on changing those methods then
OK to do in a follow up patch but if this is the code that will live in
BluetoothLocalGattCharacteristicBluez forever then I think it should conform to
existing patterns.

[rkc, 2016/04/14 21:59:38]

Once I start implementing this class, I will have a better idea of what I want
to go with. I'll decide and fix this then.

+  NOTIMPLEMENTED();
+}
+
+void BluetoothLocalGattCharacteristicBlueZ::ReadRemoteCharacteristic(
+    const ValueCallback& callback,
+    const ErrorCallback& error_callback) {
+  // Doesn't apply for a local characteristic.
+  NOTIMPLEMENTED();
+}
+
+void BluetoothLocalGattCharacteristicBlueZ::WriteRemoteCharacteristic(
+    const std::vector<uint8_t>& new_value,
+    const base::Closure& callback,
+    const ErrorCallback& error_callback) {
+  // Doesn't apply for a local characteristic.
+  NOTIMPLEMENTED();
+}
+
+}  // namespace bluez