Generalize InterfacePtrSet for [Associated]InterfacePtr.

Generalize InterfacePtrSet for [Associated]InterfacePtr.

BUG=NONE
TEST=NONE
R=yzshen@chromium.org
TBR=jam@chromium.org,sky@chromium.org

Committed: https://crrev.com/ec4355a11695298113297e35e14369dfb85832a7
Cr-Commit-Position: refs/heads/master@{#386224}

[msw, 2016-04-08 20:47:37]

Hey Yuzhu, please take a look; thanks!

[msw, 2016-04-08 20:48:19]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-08 20:48:38]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1872903003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1872903003/20001

[yzshen1, 2016-04-08 20:52:56]

LGTM with one comment. Thanks!

https://codereview.chromium.org/1872903003/diff/20001/mojo/public/cpp/binding...
File mojo/public/cpp/bindings/interface_ptr_set.h (right):

https://codereview.chromium.org/1872903003/diff/20001/mojo/public/cpp/binding...
mojo/public/cpp/bindings/interface_ptr_set.h:19: class PtrSet {
Please put this in mojo::internal namespace.

[msw, 2016-04-08 21:12:14]

https://codereview.chromium.org/1872903003/diff/20001/mojo/public/cpp/binding...
File mojo/public/cpp/bindings/interface_ptr_set.h (right):

https://codereview.chromium.org/1872903003/diff/20001/mojo/public/cpp/binding...
mojo/public/cpp/bindings/interface_ptr_set.h:19: class PtrSet {
On 2016/04/08 20:52:56, yzshen1 wrote:
> Please put this in mojo::internal namespace.

Done.

[msw, 2016-04-08 21:12:17]

The CQ bit was checked by msw@chromium.org

[msw, 2016-04-08 21:12:18]

The patchset sent to the CQ was uploaded after l-g-t-m from yzshen@chromium.org
Link to the patchset: https://codereview.chromium.org/1872903003/#ps40001
(title: "Put PtrSet in mojo::internal.")

[commit-bot: I haz the power, 2016-04-08 21:12:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1872903003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1872903003/40001

[commit-bot: I haz the power, 2016-04-08 21:27:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-08 21:27:25]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[msw, 2016-04-08 21:45:56]

Description was changed from

==========
Generalize InterfacePtrSet for [Associated]InterfacePtr.

BUG=NONE
TEST=NONE
R=yzshen@chromium.org
==========

to

==========
Generalize InterfacePtrSet for [Associated]InterfacePtr.

BUG=NONE
TEST=NONE
R=yzshen@chromium.org
TBR=jam@chromium.org,sky@chromium.org
==========

[msw, 2016-04-08 21:46:09]

msw@chromium.org changed reviewers:
+ jam@chromium.org, sky@chromium.org

[msw, 2016-04-08 21:47:06]

TBR'ing sky and jam for OWNERS review.
(just updating callsites for a function rename)

[msw, 2016-04-08 21:47:16]

The CQ bit was checked by msw@chromium.org

[commit-bot: I haz the power, 2016-04-08 21:47:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1872903003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1872903003/40001

[commit-bot: I haz the power, 2016-04-08 22:13:54]

Description was changed from

==========
Generalize InterfacePtrSet for [Associated]InterfacePtr.

BUG=NONE
TEST=NONE
R=yzshen@chromium.org
TBR=jam@chromium.org,sky@chromium.org
==========

to

==========
Generalize InterfacePtrSet for [Associated]InterfacePtr.

BUG=NONE
TEST=NONE
R=yzshen@chromium.org
TBR=jam@chromium.org,sky@chromium.org
==========

[commit-bot: I haz the power, 2016-04-08 22:13:55]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-08 22:15:33]

Description was changed from

==========
Generalize InterfacePtrSet for [Associated]InterfacePtr.

BUG=NONE
TEST=NONE
R=yzshen@chromium.org
TBR=jam@chromium.org,sky@chromium.org
==========

to

==========
Generalize InterfacePtrSet for [Associated]InterfacePtr.

BUG=NONE
TEST=NONE
R=yzshen@chromium.org
TBR=jam@chromium.org,sky@chromium.org

Committed: https://crrev.com/ec4355a11695298113297e35e14369dfb85832a7
Cr-Commit-Position: refs/heads/master@{#386224}
==========

[commit-bot: I haz the power, 2016-04-08 22:15:35]

Patchset 3 (id:??) landed as
https://crrev.com/ec4355a11695298113297e35e14369dfb85832a7
Cr-Commit-Position: refs/heads/master@{#386224}

[sky, 2016-04-08 23:13:28]

LGTM