Source/WebKit/chromium/src/WebDevToolsAgentImpl.cpp - Issue 18729002: Enable message delivering in inspector-protocol tests when on pause

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/WebKit/chromium/src/WebDevToolsAgentImpl.cpp

Issue 18729002: Enable message delivering in inspector-protocol tests when on pause (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: fix tests Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/inspector-protocol/page/javascriptDialogEvents.html ('K') | « LayoutTests/inspector-protocol/page/javascriptDialogEvents.html ('k') | Source/bindings/v8/PageScriptDebugServer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/WebKit/chromium/src/WebDevToolsAgentImpl.cpp

diff --git a/Source/WebKit/chromium/src/WebDevToolsAgentImpl.cpp b/Source/WebKit/chromium/src/WebDevToolsAgentImpl.cpp

index df2fc72cbc6a44a8b0e99561e5a7a32d05904f53..eade94a35d16669abedf704069e5110287a025fb 100644

--- a/Source/WebKit/chromium/src/WebDevToolsAgentImpl.cpp

+++ b/Source/WebKit/chromium/src/WebDevToolsAgentImpl.cpp

@@ -90,7 +90,7 @@ public:

return;

OwnPtr<ClientMessageLoopAdapter> instance = adoptPtr(new ClientMessageLoopAdapter(adoptPtr(client->createClientMessageLoop())));

s_instance = instance.get();

- PageScriptDebugServer::shared().setClientMessageLoop(instance.release());

+ PageScriptDebugServer::setClientMessageLoop(instance.release());

}

static void inspectedViewClosed(WebViewImpl* view)

@@ -363,6 +363,7 @@ WebDevToolsAgentImpl::WebDevToolsAgentImpl(

, m_attached(false)

{

ASSERT(m_hostId > 0);

+ ClientMessageLoopAdapter::ensureClientMessageLoopCreated(m_client);

}

WebDevToolsAgentImpl::~WebDevToolsAgentImpl()