Source/bindings/v8/PageScriptDebugServer.h - Issue 18729002: Enable message delivering in inspector-protocol tests when on pause

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/PageScriptDebugServer.h

Issue 18729002: Enable message delivering in inspector-protocol tests when on pause (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/WebKit/chromium/src/WebDevToolsAgentImpl.cpp ('K') | « Source/WebKit/chromium/src/WebDevToolsAgentImpl.cpp ('k') | Source/bindings/v8/PageScriptDebugServer.cpp » ('j') | Source/core/testing/InspectorFrontendClientLocal.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/v8/PageScriptDebugServer.h

diff --git a/Source/bindings/v8/PageScriptDebugServer.h b/Source/bindings/v8/PageScriptDebugServer.h

index 96a98a1e5c19332c5627ea6ead096bd0d5b81eb2..0c05bd514818cc603479c235aaeeb39bacc5e1b9 100644

--- a/Source/bindings/v8/PageScriptDebugServer.h

+++ b/Source/bindings/v8/PageScriptDebugServer.h

@@ -53,7 +53,7 @@ public:

virtual void run(Page*) = 0;

virtual void quitNow() = 0;

};

- void setClientMessageLoop(PassOwnPtr<ClientMessageLoop>);

+ static void setClientMessageLoop(PassOwnPtr<ClientMessageLoop>);

yurys 2013/07/08 11:13:04 Why are you changing this?

virtual void compileScript(ScriptState*, const String& expression, const String& sourceURL, String* scriptId, String* exceptionMessage);

virtual void clearCompiledScripts();

@@ -69,7 +69,7 @@ private:

typedef HashMap<Page*, ScriptDebugListener*> ListenersMap;

ListenersMap m_listenersMap;

- OwnPtr<ClientMessageLoop> m_clientMessageLoop;

+ static OwnPtr<ClientMessageLoop> m_clientMessageLoop;

yurys 2013/07/08 11:13:04 We regularly don't use classes as types of static

Page* m_pausedPage;

HashMap<String, String> m_compiledScriptURLs;

};