Enable message delivering in inspector-protocol tests when on pause

Source/core/testing/InspectorFrontendClientLocal.cpp

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 19 matching lines @@
 
 #include "config.h"
 #include "InspectorFrontendClientLocal.h"
 
 #include "bindings/v8/ScriptObject.h"
 #include "core/inspector/InspectorController.h"
 #include "core/inspector/InspectorFrontendHost.h"
 #include "core/page/Page.h"
 #include "core/page/Settings.h"
 #include "core/platform/Timer.h"
+#include "public/platform/Platform.h"
+#include "public/platform/WebThread.h"
 #include <wtf/Deque.h>
 #include <wtf/text/WTFString.h>
 
 namespace WebCore {
 
 class InspectorBackendDispatchTask {
     WTF_MAKE_FAST_ALLOCATED;
 public:
     InspectorBackendDispatchTask(InspectorController* inspectorController)
         : m_inspectorController(inspectorController)
-        , m_timer(this, &InspectorBackendDispatchTask::onTimer)
     {
     }
 
     void dispatch(const String& message)
     {
         m_messages.append(message);
-        if (!m_timer.isActive())
-            m_timer.startOneShot(0);
+        schedule();
     }
 
     void reset()
     {
         m_messages.clear();
-        m_timer.stop();
     }
 
-    void onTimer(Timer<InspectorBackendDispatchTask>*)
+private:
+    void schedule()
+    {
+        class TaskImpl : public WebKit::WebThread::Task {
+        public:
+            InspectorBackendDispatchTask* owner;
+            virtual void run()
+            {
+                owner->onTimer();

[aandrey, 2013/07/05 09:31:56]

can this execute after owner is destructed?

[Peter.Rybin, 2013/07/10 21:24:25]

I guess the old implementation didn't care about it. I also took a look and saw,
that the main class is being destructed pretty late, so that problem must be
unlikely.

+            }
+        };
+        TaskImpl* taskImpl = new TaskImpl;
+        taskImpl->owner = this;
+        WebKit::Platform::current()->currentThread()->postDelayedTask(taskImpl, 0);

[yurys, 2013/07/08 11:13:04]

Does it guarantee the sequence of execution for the tasks posted with the same
delay?

[Peter.Rybin, 2013/07/08 12:23:38]

You mean order of execution? I am not sure.
But anyway, I don't think the order matters, since all the actual tasks are
identical.

[yurys, 2013/07/08 13:16:11]

You are right. But if the order of execution is guaranteed then we could get rid
of our own message queue and simply post all dispatch tasks to the thread's
loop.

+    }
+
+    void onTimer()
     {
         if (!m_messages.isEmpty()) {
             // Dispatch can lead to the timer destruction -> schedule the next shot first.
-            m_timer.startOneShot(0);
+            schedule();
             m_inspectorController->dispatchMessageFromFrontend(m_messages.takeFirst());
         }
     }
 
-private:
     InspectorController* m_inspectorController;
-    Timer<InspectorBackendDispatchTask> m_timer;
     Deque<String> m_messages;
 };
 
 InspectorFrontendClientLocal::InspectorFrontendClientLocal(InspectorController* inspectorController, Page* frontendPage)
     : m_inspectorController(inspectorController)
     , m_frontendPage(frontendPage)
 {
     m_frontendPage->settings()->setAllowFileAccessFromFileURLs(true);
     m_dispatchTask = adoptPtr(new InspectorBackendDispatchTask(inspectorController));
 }
@@ skipping 15 matching lines @@
     ScriptGlobalObject::set(frontendScriptState, "InspectorFrontendHost", m_frontendHost.get());
 }
 
 void InspectorFrontendClientLocal::sendMessageToBackend(const String& message)
 {
     m_dispatchTask->dispatch(message);
 }
 
 } // namespace WebCore