Source/bindings/v8/PageScriptDebugServer.h - Issue 18729002: Enable message delivering in inspector-protocol tests when on pause

Side by Side Diff: Source/bindings/v8/PageScriptDebugServer.h

Issue 18729002: Enable message delivering in inspector-protocol tests when on pause (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« Source/WebKit/chromium/src/WebDevToolsAgentImpl.cpp ('K') | « Source/WebKit/chromium/src/WebDevToolsAgentImpl.cpp ('k') | Source/bindings/v8/PageScriptDebugServer.cpp » ('j') | Source/core/testing/InspectorFrontendClientLocal.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (c) 2011 Google Inc. All rights reserved.	2 * Copyright (c) 2011 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions are	5 * modification, are permitted provided that the following conditions are

6 * met:	6 * met:

7 *	7 *

8 * * Redistributions of source code must retain the above copyright	8 * * Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * * Redistributions in binary form must reproduce the above	10 * * Redistributions in binary form must reproduce the above

(...skipping 35 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
46	46

47 void addListener(ScriptDebugListener, Page);	47 void addListener(ScriptDebugListener, Page);

48 void removeListener(ScriptDebugListener, Page);	48 void removeListener(ScriptDebugListener, Page);

49	49

50 class ClientMessageLoop {	50 class ClientMessageLoop {

51 public:	51 public:

52 virtual ~ClientMessageLoop() { }	52 virtual ~ClientMessageLoop() { }

53 virtual void run(Page*) = 0;	53 virtual void run(Page*) = 0;

54 virtual void quitNow() = 0;	54 virtual void quitNow() = 0;

55 };	55 };

56 void setClientMessageLoop(PassOwnPtr<ClientMessageLoop>);	56 static void setClientMessageLoop(PassOwnPtr<ClientMessageLoop>);
	yurys 2013/07/08 11:13:04 Why are you changing this? Why are you changing this?
57	57

58 virtual void compileScript(ScriptState, const String& expression, const Str ing& sourceURL, String scriptId, String* exceptionMessage);	58 virtual void compileScript(ScriptState, const String& expression, const Str ing& sourceURL, String scriptId, String* exceptionMessage);

59 virtual void clearCompiledScripts();	59 virtual void clearCompiledScripts();

60 virtual void runScript(ScriptState, const String& scriptId, ScriptValue re sult, bool* wasThrown, String* exceptionMessage);	60 virtual void runScript(ScriptState, const String& scriptId, ScriptValue re sult, bool* wasThrown, String* exceptionMessage);

61	61

62 private:	62 private:

63 PageScriptDebugServer();	63 PageScriptDebugServer();

64 virtual ~PageScriptDebugServer() { }	64 virtual ~PageScriptDebugServer() { }

65	65

66 virtual ScriptDebugListener* getDebugListenerForContext(v8::Handle<v8::Conte xt>);	66 virtual ScriptDebugListener* getDebugListenerForContext(v8::Handle<v8::Conte xt>);

67 virtual void runMessageLoopOnPause(v8::Handle<v8::Context>);	67 virtual void runMessageLoopOnPause(v8::Handle<v8::Context>);

68 virtual void quitMessageLoopOnPause();	68 virtual void quitMessageLoopOnPause();

69	69

70 typedef HashMap<Page, ScriptDebugListener> ListenersMap;	70 typedef HashMap<Page, ScriptDebugListener> ListenersMap;

71 ListenersMap m_listenersMap;	71 ListenersMap m_listenersMap;

72 OwnPtr<ClientMessageLoop> m_clientMessageLoop;	72 static OwnPtr<ClientMessageLoop> m_clientMessageLoop;
	yurys 2013/07/08 11:13:04 We regularly don't use classes as types of static We regularly don't use classes as types of static members because of possible problems with their destruction at shutdown time. DEFINE_STATIC_LOCAL should be used instead. In this particular case you already have PageScriptDebugServer::shared and I don't see why to make this particular field static.
73 Page* m_pausedPage;	73 Page* m_pausedPage;

74 HashMap<String, String> m_compiledScriptURLs;	74 HashMap<String, String> m_compiledScriptURLs;

75 };	75 };

76	76

77 } // namespace WebCore	77 } // namespace WebCore

78	78

79	79

80 #endif // PageScriptDebugServer_h	80 #endif // PageScriptDebugServer_h

OLD	NEW