Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 1872873002: Add autotestPrivate.getVisibleNotifications API (Closed)

Created:
4 years, 8 months ago by victorhsieh0
Modified:
4 years, 6 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, asvitkine+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add autotestPrivate.getVisibleNotifications API This private API allows autotest test cases to inspect Chrome notifications. TEST=(chromeos=1 on Linux) out/Debug/browser_tests --gtest_filter=ExtensionApiTest.AutotestPrivate TEST=The new autotest passed BUG=b:27850100 Committed: https://crrev.com/8fbe937a856f5ad28068f61dc1823b7e29f1ff9f Cr-Commit-Position: refs/heads/master@{#386454}

Patch Set 1 #

Total comments: 9

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -0 lines) Patch
M chrome/browser/extensions/api/autotest_private/autotest_private_api.h View 2 chunks +14 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/autotest_private/autotest_private_api.cc View 1 2 chunks +43 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/autotest_private.idl View 1 2 chunks +16 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/autotest_private/test.js View 1 chunk +4 lines, -0 lines 0 comments Download
M extensions/browser/extension_function_histogram_value.h View 1 chunk +1 line, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 20 (7 generated)
victorhsieh0
finnur@, PTAL at chrome/.../autotest* asvitkine@, PTAL at *histogram* yoshiki@, PTAL in general
4 years, 8 months ago (2016-04-08 19:08:56 UTC) #2
victorhsieh0
https://codereview.chromium.org/1872873002/diff/1/chrome/common/extensions/api/autotest_private.idl File chrome/common/extensions/api/autotest_private.idl (right): https://codereview.chromium.org/1872873002/diff/1/chrome/common/extensions/api/autotest_private.idl#newcode56 chrome/common/extensions/api/autotest_private.idl:56: dictionary Notification { yoshiki@, I tentatively added these fields, ...
4 years, 8 months ago (2016-04-08 19:11:12 UTC) #3
yoshiki
lgtm with nits https://codereview.chromium.org/1872873002/diff/1/chrome/browser/extensions/api/autotest_private/autotest_private_api.cc File chrome/browser/extensions/api/autotest_private/autotest_private_api.cc (right): https://codereview.chromium.org/1872873002/diff/1/chrome/browser/extensions/api/autotest_private/autotest_private_api.cc#newcode328 chrome/browser/extensions/api/autotest_private/autotest_private_api.cc:328: std::string AutotestPrivateGetVisibleNotificationsFunction::ConvertToString( You need to wrap ...
4 years, 8 months ago (2016-04-11 04:41:47 UTC) #4
yoshiki
https://codereview.chromium.org/1872873002/diff/1/chrome/common/extensions/api/autotest_private.idl File chrome/common/extensions/api/autotest_private.idl (right): https://codereview.chromium.org/1872873002/diff/1/chrome/common/extensions/api/autotest_private.idl#newcode56 chrome/common/extensions/api/autotest_private.idl:56: dictionary Notification { On 2016/04/08 19:11:12, victorhsieh0 wrote: > ...
4 years, 8 months ago (2016-04-11 04:49:46 UTC) #5
Finnur
chrome/.../autotest* LGTM, pending answer to the below. https://codereview.chromium.org/1872873002/diff/1/chrome/browser/extensions/api/autotest_private/DEPS File chrome/browser/extensions/api/autotest_private/DEPS (right): https://codereview.chromium.org/1872873002/diff/1/chrome/browser/extensions/api/autotest_private/DEPS#newcode2 chrome/browser/extensions/api/autotest_private/DEPS:2: "+ui/message_center", Is ...
4 years, 8 months ago (2016-04-11 15:03:37 UTC) #6
victorhsieh0
https://codereview.chromium.org/1872873002/diff/1/chrome/browser/extensions/api/autotest_private/DEPS File chrome/browser/extensions/api/autotest_private/DEPS (right): https://codereview.chromium.org/1872873002/diff/1/chrome/browser/extensions/api/autotest_private/DEPS#newcode2 chrome/browser/extensions/api/autotest_private/DEPS:2: "+ui/message_center", On 2016/04/11 15:03:37, Finnur wrote: > Is this ...
4 years, 8 months ago (2016-04-11 18:28:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1872873002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1872873002/20001
4 years, 8 months ago (2016-04-11 18:29:51 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/167031)
4 years, 8 months ago (2016-04-11 18:42:46 UTC) #12
victorhsieh0
asvitkine@, PTAL at extensions/browser/extension_function_histogram_value.h tools/metrics/histograms/histograms.xml
4 years, 8 months ago (2016-04-11 19:18:31 UTC) #14
Alexei Svitkine (slow)
lgtm
4 years, 8 months ago (2016-04-11 20:01:38 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1872873002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1872873002/20001
4 years, 8 months ago (2016-04-11 20:04:35 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-11 20:12:04 UTC) #18
commit-bot: I haz the power
4 years, 8 months ago (2016-04-11 20:13:55 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8fbe937a856f5ad28068f61dc1823b7e29f1ff9f
Cr-Commit-Position: refs/heads/master@{#386454}

Powered by Google App Engine
This is Rietveld 408576698