tests/DataRefTest.cpp - Issue 1872853002: Fix race condition in SkROBuffer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/DataRefTest.cpp

Issue 1872853002: Fix race condition in SkROBuffer. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: use constructors to make fCapacity const Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tests/DataRefTest.cpp

diff --git a/tests/DataRefTest.cpp b/tests/DataRefTest.cpp

index 03b80fb2af4683ffe97bd8ce24e68f2340a35cf7..002abcbe894a816301db7383c17adb79d10a9880 100644

--- a/tests/DataRefTest.cpp

+++ b/tests/DataRefTest.cpp

@@ -294,11 +294,7 @@ DEF_TEST(RWBuffer, reporter) {

{

SkRWBuffer buffer;

for (int i = 0; i < N; ++i) {

- if (0 == (i & 1)) {

- buffer.append(gABC, 26);

- } else {

- memcpy(buffer.append(26), gABC, 26);

- }

+ buffer.append(gABC, 26);

readers[i] = buffer.newRBufferSnapshot();

streams[i] = buffer.newStreamSnapshot();

}

« no previous file with comments | « src/core/SkRWBuffer.cpp ('k') | no next file » | no next file with comments »