Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 1872833002: [compiler] Move tracing from backends to compiler. (Closed)

Created:
4 years, 8 months ago by Michael Starzinger
Modified:
4 years, 8 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_cleanup-compiler-simplify-5
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[compiler] Move tracing from backends to compiler. R=bmeurer@chromium.org Committed: https://crrev.com/318cc682f49e98c3acb3b9a6c41282c4e495a654 Cr-Commit-Position: refs/heads/master@{#35384}

Patch Set 1 #

Patch Set 2 : Fix typo. #

Patch Set 3 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -20 lines) Patch
M src/compiler.h View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M src/compiler.cc View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M src/compiler/pipeline.cc View 1 2 2 chunks +1 line, -9 lines 0 comments Download
M src/crankshaft/hydrogen.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/crankshaft/hydrogen.cc View 1 2 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Michael Starzinger
4 years, 8 months ago (2016-04-08 17:06:15 UTC) #2
Benedikt Meurer
LGTM.
4 years, 8 months ago (2016-04-09 16:54:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1872833002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1872833002/60001
4 years, 8 months ago (2016-04-11 12:04:45 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 8 months ago (2016-04-11 12:06:45 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-11 12:07:56 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/318cc682f49e98c3acb3b9a6c41282c4e495a654
Cr-Commit-Position: refs/heads/master@{#35384}

Powered by Google App Engine
This is Rietveld 408576698