Issue 187283006: Add RawPtr constructor taking a reference argument.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 187283006: Add RawPtr constructor taking a reference argument. (Closed)

Created:
6 years, 9 months ago by tkent

Modified:
6 years, 9 months ago

Reviewers:
haraken, Inactive, Mikhail

CC:
blink-reviews, Mikhail, adamk+blink_chromium.org, Inactive, abarth-chromium

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Add RawPtr constructor taking a reference argument. This fixed build failures with ENABLE_OILPAN after [1]. [1] http://src.chromium.org/viewvc/blink?view=revision&revision=168422 BUG= TBR=haraken@chromium.org, ch.dumez@samsung.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168433

Patch Set 1 #

Total comments: 1

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	Source/wtf/RawPtr.h	View		1 chunk	+1 line, -0 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

tkent

Committed patchset #1 manually as r168433 (presubmit successful).

6 years, 9 months ago (2014-03-05 05:43:43 UTC) #1

Mikhail

6 years, 9 months ago (2014-03-05 06:33:43 UTC) #3

Message was sent while issue was closed.

https://codereview.chromium.org/187283006/diff/1/Source/wtf/RawPtr.h
File Source/wtf/RawPtr.h (right):

https://codereview.chromium.org/187283006/diff/1/Source/wtf/RawPtr.h#newcode54
Source/wtf/RawPtr.h:54: RawPtr(T& reference) : m_ptr(&reference) { }
Shouldn't it be explicit? (to prevent from accidental deleting of a non-heap
allocated object)

Expand Messages | Collapse Messages