Issue 187283005: Be more aggressive about breaking locks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 187283005: Be more aggressive about breaking locks (Closed)

Created:
6 years, 9 months ago by Ryan Tseng

Modified:
6 years, 9 months ago

Reviewers:
agable

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Visibility:
Public.

More Reviews

Description

Be more aggressive about breaking locks There is an issue where: 1. Lock for asdf.git acquires, which creates asdf.lock 2. asdf.git is cloned into tmp_asdf.git 3. Buildbot crashes, because timeouts 4. neither asdf.lock or tmp_asdf.git/config.lock gets cleaned out on the next unlock. This aims to fix this issue by aggressively unlocking everything it can find that vaguely resembles a lock. BUG=339171 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=255138