Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 1872813002: Switching iOS to use BoringSSL (Closed)

Created:
4 years, 8 months ago by svaldez
Modified:
4 years, 8 months ago
Reviewers:
Nico, Ryan Sleevi, scottmg
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@ios
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Switching iOS to use BoringSSL This switches use_openssl on for iOS. BUG=591545 Committed: https://crrev.com/88283eca96ddc06440a778132f969a3e8360dbbf Cr-Commit-Position: refs/heads/master@{#387011}

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Rebasing. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -8 lines) Patch
M build/common.gypi View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M build/config/crypto.gni View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 23 (12 generated)
svaldez
Final CL to flip the use_openssl flag on iOS, once all the other CLs are ...
4 years, 8 months ago (2016-04-08 15:30:01 UTC) #2
Ryan Sleevi
LGTM % other CLs
4 years, 8 months ago (2016-04-08 20:02:33 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1872813002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1872813002/20001
4 years, 8 months ago (2016-04-13 14:59:58 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1872813002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1872813002/40001
4 years, 8 months ago (2016-04-13 15:27:26 UTC) #10
svaldez
Hi, Could you take a look at these build changes. This is the change to ...
4 years, 8 months ago (2016-04-13 15:36:07 UTC) #12
svaldez
4 years, 8 months ago (2016-04-13 15:38:50 UTC) #14
Nico
lgtm, but please say something like "thakis, scottmg: owners stamp for build" when you add ...
4 years, 8 months ago (2016-04-13 15:52:02 UTC) #15
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/49752) cast_shell_android on ...
4 years, 8 months ago (2016-04-13 16:16:23 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1872813002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1872813002/40001
4 years, 8 months ago (2016-04-13 16:23:21 UTC) #20
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-13 17:13:29 UTC) #21
commit-bot: I haz the power
4 years, 8 months ago (2016-04-13 17:15:03 UTC) #23
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/88283eca96ddc06440a778132f969a3e8360dbbf
Cr-Commit-Position: refs/heads/master@{#387011}

Powered by Google App Engine
This is Rietveld 408576698