|
|
DescriptionSwitching iOS to use BoringSSL
This switches use_openssl on for iOS.
BUG=591545
Committed: https://crrev.com/88283eca96ddc06440a778132f969a3e8360dbbf
Cr-Commit-Position: refs/heads/master@{#387011}
Patch Set 1 #Patch Set 2 : Rebase. #Patch Set 3 : Rebasing. #
Messages
Total messages: 23 (12 generated)
svaldez@chromium.org changed reviewers: + rsleevi@chromium.org
Final CL to flip the use_openssl flag on iOS, once all the other CLs are finished.
LGTM % other CLs
The CQ bit was checked by svaldez@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from rsleevi@chromium.org Link to the patchset: https://codereview.chromium.org/1872813002/#ps20001 (title: "Rebase.")
The CQ bit was unchecked by svaldez@chromium.org
The CQ bit was checked by svaldez@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1872813002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1872813002/20001
The CQ bit was checked by svaldez@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1872813002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1872813002/40001
svaldez@chromium.org changed reviewers: + scottmg@chromium.org
Hi, Could you take a look at these build changes. This is the change to switch over iOS to use BoringSSL instead of NSS. We'll be completely removing the use_openssl flags and defines, as well as most of the remaining NSS code in a separate CL.
svaldez@chromium.org changed reviewers: + thakis@chromium.org
lgtm, but please say something like "thakis, scottmg: owners stamp for build" when you add people mid-review. This is how this looked in my inbox: http://imgur.com/AOVIspD without clicking through, it wasn't clear what you wanted.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...) cast_shell_android on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...) linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by svaldez@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from rsleevi@chromium.org Link to the patchset: https://codereview.chromium.org/1872813002/#ps40001 (title: "Rebasing.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1872813002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1872813002/40001
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Switching iOS to use BoringSSL This switches use_openssl on for iOS. BUG=591545 ========== to ========== Switching iOS to use BoringSSL This switches use_openssl on for iOS. BUG=591545 Committed: https://crrev.com/88283eca96ddc06440a778132f969a3e8360dbbf Cr-Commit-Position: refs/heads/master@{#387011} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/88283eca96ddc06440a778132f969a3e8360dbbf Cr-Commit-Position: refs/heads/master@{#387011} |