Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 1872763002: [CT] Split benchmarkArgs around one or more consecutive white spaces (Closed)

Created:
4 years, 8 months ago by rmistry
Modified:
4 years, 8 months ago
Reviewers:
dogben
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/buildbot@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[CT] Split benchmarkArgs around one or more consecutive white spaces Caused a bug when benchmark args where "--output-format=csv-pivot-table --use-live-sites" (notice the 2 spaces) run_benchmark failed with "run_benchmark: error: Too many arguments.". BUG=skia: TBR=benjaminwagner Committed: https://skia.googlesource.com/buildbot/+/93ec8db44004af342bd74dcf33ead26bd9dc7310

Patch Set 1 : Initial upload #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M ct/go/worker_scripts/fix_archives/main.go View 1 chunk +1 line, -1 line 0 comments Download
M ct/go/worker_scripts/run_chromium_perf/main.go View 1 chunk +1 line, -1 line 0 comments Download
M ct/go/worker_scripts/run_chromium_perf_swarming/main.go View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1872763002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1872763002/1
4 years, 8 months ago (2016-04-08 12:45:02 UTC) #2
rmistry
4 years, 8 months ago (2016-04-08 12:46:00 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-08 12:47:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1872763002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1872763002/1
4 years, 8 months ago (2016-04-08 12:48:12 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/buildbot/+/93ec8db44004af342bd74dcf33ead26bd9dc7310
4 years, 8 months ago (2016-04-08 12:48:30 UTC) #12
dogben
LGTM nit: append(args, strings.Fields(*benchmarkExtraArgs)...) in all three places.
4 years, 8 months ago (2016-04-08 13:15:33 UTC) #13
rmistry
4 years, 8 months ago (2016-04-11 11:24:41 UTC) #14
Message was sent while issue was closed.
On 2016/04/08 13:15:33, Ben Wagner wrote:
> LGTM
> 
> nit: append(args, strings.Fields(*benchmarkExtraArgs)...) in all three places.

Fixes were made in https://codereview.chromium.org/1870173002

Powered by Google App Engine
This is Rietveld 408576698