Fix the vertical scroll animation on the new tab page when scrolling up

Fix the vertical scroll animation on the new tab page when scrolling up

Videos:
https://drive.google.com/corp/drive/u/0/folders/0B1IgAIJ9cgizemNwMGgzN1V1ckE

BUG=599888
Committed: https://crrev.com/8d5819b2a90fc9b10fac1a2713a3f74bcfb82e29
Cr-Commit-Position: refs/heads/master@{#386093}

[mcwilliams, 2016-04-08 10:44:57]

Description was changed from

==========
Fix the vertical scroll animation on the new tab page when scrolling up

BUG=599888
==========

to

==========
Fix the vertical scroll animation on the new tab page when scrolling up

Videos:
https://drive.google.com/corp/drive/u/0/folders/0B1IgAIJ9cgizemNwMGgzN1V1ckE

BUG=599888
==========

[mcwilliams, 2016-04-08 10:44:58]

mcwilliams@chromium.org changed reviewers:
+ bauerb@chromium.org

[Bernhard Bauer, 2016-04-08 14:17:26]

Nice! LGTM with a nit:

https://codereview.chromium.org/1872743002/diff/1/chrome/android/java/src/org...
File chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
(left):

https://codereview.chromium.org/1872743002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java:649:
transformedBounds.offset(-((RecyclerView) view).computeHorizontalScrollOffset(),
Extract the casted (cast?) view into a local variable?

[mcwilliams, 2016-04-08 15:29:21]

On 2016/04/08 14:17:26, Bernhard Bauer wrote:
> Nice! LGTM with a nit:
> 
>
https://codereview.chromium.org/1872743002/diff/1/chrome/android/java/src/org...
> File
chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
> (left):
> 
>
https://codereview.chromium.org/1872743002/diff/1/chrome/android/java/src/org...
>
chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java:649:
> transformedBounds.offset(-((RecyclerView)
view).computeHorizontalScrollOffset(),
> Extract the casted (cast?) view into a local variable?

As discussed offline - this code is getting deleted :)

[mcwilliams, 2016-04-08 15:29:24]

The CQ bit was checked by mcwilliams@chromium.org

[commit-bot: I haz the power, 2016-04-08 15:29:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1872743002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1872743002/1

[commit-bot: I haz the power, 2016-04-08 16:12:35]

Description was changed from

==========
Fix the vertical scroll animation on the new tab page when scrolling up

Videos:
https://drive.google.com/corp/drive/u/0/folders/0B1IgAIJ9cgizemNwMGgzN1V1ckE

BUG=599888
==========

to

==========
Fix the vertical scroll animation on the new tab page when scrolling up

Videos:
https://drive.google.com/corp/drive/u/0/folders/0B1IgAIJ9cgizemNwMGgzN1V1ckE

BUG=599888
==========

[commit-bot: I haz the power, 2016-04-08 16:12:36]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-04-08 16:14:15]

Description was changed from

==========
Fix the vertical scroll animation on the new tab page when scrolling up

Videos:
https://drive.google.com/corp/drive/u/0/folders/0B1IgAIJ9cgizemNwMGgzN1V1ckE

BUG=599888
==========

to

==========
Fix the vertical scroll animation on the new tab page when scrolling up

Videos:
https://drive.google.com/corp/drive/u/0/folders/0B1IgAIJ9cgizemNwMGgzN1V1ckE

BUG=599888

Committed: https://crrev.com/8d5819b2a90fc9b10fac1a2713a3f74bcfb82e29
Cr-Commit-Position: refs/heads/master@{#386093}
==========

[commit-bot: I haz the power, 2016-04-08 16:14:15]

Patchset 1 (id:??) landed as
https://crrev.com/8d5819b2a90fc9b10fac1a2713a3f74bcfb82e29
Cr-Commit-Position: refs/heads/master@{#386093}