net/http/http_response_headers.cc - Issue 187273002: Fixed chrome proxy via check

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_response_headers.cc

Issue 187273002: Fixed chrome proxy via check (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/http/http_response_headers.cc

diff --git a/net/http/http_response_headers.cc b/net/http/http_response_headers.cc

index 0072976ada2e16891a487683d7c2ed1dd214be71..1c83d7f17b97b8c57ea96da76f492962e618b3ad 100644

--- a/net/http/http_response_headers.cc

+++ b/net/http/http_response_headers.cc

@@ -1431,7 +1431,8 @@ bool HttpResponseHeaders::IsChromeProxyResponse() const {

// space following it are always |kVersionSize| characters. E.g.,

// 'Via: 1.1 Chrome-Compression-Proxy'

while (EnumerateHeader(&iter, "via", &value)) {

- if (!value.compare(kVersionSize, value_len, kChromeProxyViaValue))

+ if (value.size() >= kVersionSize + value_len &&

+ !value.compare(kVersionSize, value_len, kChromeProxyViaValue))

return true;

}

« no previous file with comments | « no previous file | net/http/http_response_headers_unittest.cc » ('j') | no next file with comments »