Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Issue 1872643002: Add ffmpeg security regression test (Closed)

Created:
4 years, 8 months ago by tguilbert
Modified:
4 years, 8 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add ffmpeg security regression test Adds a test for the clusterfuzz failures found in ASAN builds. See crbug.com/599625 and crbug.com/599846 BUG=601603 TEST=ran ffmpeg_regression_test, with and without the fix REVIEW=dalecurtis Committed: https://crrev.com/fdd3baca0c7713dddbfc97585ca9a854ea4747b4 Cr-Commit-Position: refs/heads/master@{#385961}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M media/ffmpeg/ffmpeg_regression_tests.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
tguilbert
I will wait until https://codereview.chromium.org/1868983004/ has finished submitting. Dale, can you upload the media into ...
4 years, 8 months ago (2016-04-07 23:13:38 UTC) #2
DaleCurtis
Done. Pushed up. lgtm
4 years, 8 months ago (2016-04-08 00:15:32 UTC) #3
DaleCurtis
If you're able to see https://chrome-internal.googlesource.com/chrome/data/media# it's shown there :)
4 years, 8 months ago (2016-04-08 00:15:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1872643002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1872643002/1
4 years, 8 months ago (2016-04-08 00:41:22 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-08 03:06:08 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-08 03:08:52 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fdd3baca0c7713dddbfc97585ca9a854ea4747b4
Cr-Commit-Position: refs/heads/master@{#385961}

Powered by Google App Engine
This is Rietveld 408576698