Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Unified Diff: pkg/barback/lib/src/phase_forwarder.dart

Issue 187263003: Move Barback to a more thoroughly push-based model. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: code review Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/barback/lib/src/phase.dart ('k') | pkg/barback/lib/src/phase_input.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/barback/lib/src/phase_forwarder.dart
diff --git a/pkg/barback/lib/src/phase_forwarder.dart b/pkg/barback/lib/src/phase_forwarder.dart
index c1f7abdf76443adeff002eaf27287513102cb9ee..1e0d3fead9d8d1f5a345c10fdf4d3844974626c5 100644
--- a/pkg/barback/lib/src/phase_forwarder.dart
+++ b/pkg/barback/lib/src/phase_forwarder.dart
@@ -53,9 +53,8 @@ class PhaseForwarder {
///
/// Whenever this stream emits an event, the value will be identical to
/// [output].
- Stream<AssetNode> get onForwarding => _onForwardingController.stream;
- final _onForwardingController =
- new StreamController<AssetNode>.broadcast(sync: true);
+ Stream<AssetNode> get onAsset => _onAssetController.stream;
+ final _onAssetController = new StreamController<AssetNode>(sync: true);
PhaseForwarder(this._numChannels);
@@ -86,7 +85,7 @@ class PhaseForwarder {
_outputController.setRemoved();
_outputController = null;
}
- _onForwardingController.close();
+ _onAssetController.close();
}
/// Adjusts [output] to ensure that it accurately reflects the current state
@@ -112,7 +111,7 @@ class PhaseForwarder {
(asset) => asset.state.isDirty,
orElse: () => _intermediateAssets.first);
_outputController = new AssetNodeController.from(finalAsset);
- _onForwardingController.add(output);
+ _onAssetController.add(output);
return;
}
« no previous file with comments | « pkg/barback/lib/src/phase.dart ('k') | pkg/barback/lib/src/phase_input.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698