Refactor Authenticated Server Requests to use Promises

chrome/browser/resources/google_now/utility.js

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 'use strict';
 
 /**
  * @fileoverview Utility objects and functions for Google Now extension.
  * Most important entities here:
  * (1) 'wrapper' is a module used to add error handling and other services to
@@ skipping 84 matching lines @@
  */
 function verify(condition, message) {
   if (!condition)
     throw buildErrorWithMessageForServer('ASSERT: ' + message);
 }
 
 /**
  * Builds a request to the notification server.
  * @param {string} method Request method.
  * @param {string} handlerName Server handler to send the request to.
- * @param {string=} contentType Value for the Content-type header.
+ * @param {string=} opt_contentType Value for the Content-type header.
  * @return {XMLHttpRequest} Server request.
  */
-function buildServerRequest(method, handlerName, contentType) {
+function buildServerRequest(method, handlerName, opt_contentType) {
   var request = new XMLHttpRequest();
 
   request.responseType = 'text';
   request.open(method, NOTIFICATION_CARDS_URL + '/' + handlerName, true);
-  if (contentType)
-    request.setRequestHeader('Content-type', contentType);
+  if (opt_contentType)
+    request.setRequestHeader('Content-type', opt_contentType);
 
   return request;
 }
 
 /**
  * Sends an error report to the server.
  * @param {Error} error Error to send.
  */
 function sendErrorReport(error) {
   // Don't remove 'error.stack.replace' below!
@@ skipping 37 matching lines @@
   if (error.canSendMessageToServer)
     errorText = errorText + ': ' + error.message;
 
   var errorObject = {
     message: errorText,
     file: file,
     line: line,
     trace: filteredStack
   };
 
+  // We use relatively direct calls here because the instrumentation may be in
+  // a bad state. Wrappers and promises should not be involved in the reporting.
   var request = buildServerRequest('POST', 'jserrors', 'application/json');
   request.onloadend = function(event) {
     console.log('sendErrorReport status: ' + request.status);
   };
 
   chrome.identity.getAuthToken({interactive: false}, function(token) {
     if (token) {
       request.setRequestHeader('Authorization', 'Bearer ' + token);
       request.send(JSON.stringify(errorObject));
     }
@@ skipping 843 matching lines @@
   // One hour is just an arbitrary amount of time chosen.
   chrome.alarms.create(alarmName, {periodInMinutes: 60});
 
   return {
     addListener: addListener,
     getAuthToken: getAuthToken,
     isSignedIn: isSignedIn,
     removeToken: removeToken
   };
 }