Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(630)

Issue 1872553005: Don't create new descriptor set for vulkan uniforms every draw (Closed)

Created:
4 years, 8 months ago by egdaniel
Modified:
4 years, 8 months ago
Reviewers:
jvanverth1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -13 lines) Patch
M src/gpu/vk/GrVkBuffer.h View 1 chunk +4 lines, -1 line 0 comments Download
M src/gpu/vk/GrVkBuffer.cpp View 2 chunks +5 lines, -1 line 0 comments Download
M src/gpu/vk/GrVkPipelineState.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M src/gpu/vk/GrVkPipelineStateDataManager.h View 1 chunk +4 lines, -1 line 0 comments Download
M src/gpu/vk/GrVkPipelineStateDataManager.cpp View 3 chunks +6 lines, -3 lines 0 comments Download
M src/gpu/vk/GrVkUniformBuffer.h View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
egdaniel
4 years, 8 months ago (2016-04-08 17:39:14 UTC) #3
jvanverth1
lgtm
4 years, 8 months ago (2016-04-08 19:01:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1872553005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1872553005/1
4 years, 8 months ago (2016-04-08 20:18:36 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-08 20:27:56 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/7cbffda6c85e0634399d74607db2a82943abe06a

Powered by Google App Engine
This is Rietveld 408576698