Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 1872523003: Update error message with live URL for enabling trials (Closed)

Created:
4 years, 8 months ago by chasej
Modified:
4 years, 8 months ago
Reviewers:
Rick Byers
CC:
chromium-reviews, blink-reviews, chasej+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update error message with live URL for enabling trials Update the message shown in the dev console to have a real URL. The URL is https://bit.ly/OriginTrials, but isn't actually live yet. It will be available soon, when a blog post is published. BUG=590222 Committed: https://crrev.com/f9499b969c76de97e6f85f54e73988b255ad64fa Cr-Commit-Position: refs/heads/master@{#386762}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/origin_trials/OriginTrialContext.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
chasej
rbyers, please take a look.
4 years, 8 months ago (2016-04-07 21:15:18 UTC) #2
chasej
rbyers, please take a look.
4 years, 8 months ago (2016-04-12 17:18:47 UTC) #3
Rick Byers
LGTM Do we record metrics on how often this message is generated? We want to ...
4 years, 8 months ago (2016-04-12 19:07:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1872523003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1872523003/20001
4 years, 8 months ago (2016-04-12 19:12:13 UTC) #6
chasej
On 2016/04/12 19:07:55, Rick Byers wrote: > LGTM > > Do we record metrics on ...
4 years, 8 months ago (2016-04-12 19:22:06 UTC) #7
Rick Byers
On 2016/04/12 19:22:06, chasej wrote: > On 2016/04/12 19:07:55, Rick Byers wrote: > > LGTM ...
4 years, 8 months ago (2016-04-12 19:34:25 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-12 19:36:21 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-12 19:38:47 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f9499b969c76de97e6f85f54e73988b255ad64fa
Cr-Commit-Position: refs/heads/master@{#386762}

Powered by Google App Engine
This is Rietveld 408576698