Update error message with live URL for enabling trials

Update error message with live URL for enabling trials

Update the message shown in the dev console to have a real URL. The URL
is https://bit.ly/OriginTrials, but isn't actually live yet. It will be
available soon, when a blog post is published.

BUG=590222
Committed: https://crrev.com/f9499b969c76de97e6f85f54e73988b255ad64fa
Cr-Commit-Position: refs/heads/master@{#386762}

[chasej, 2016-04-07 21:15:18]

chasej@chromium.org changed reviewers:
+ rbyers@chromium.org

[chasej, 2016-04-07 21:15:18]

rbyers, please take a look.

[chasej, 2016-04-12 17:18:47]

rbyers, please take a look.

[Rick Byers, 2016-04-12 19:07:55]

LGTM

Do we record metrics on how often this message is generated?  We want to really
avoid console spam, I'm kind of worried about the impact on this of code that
does generic enumeration (eg. we've had this problem with deprecation messages
on members of Event - it's very common for JS to blindly enumerate all Event
member).  I think it's fine for now (no obvious general solution) but I would
like to make sure we can tell if the occurrences of this warning skyrocket
somehow.

[chasej, 2016-04-12 19:11:53]

The CQ bit was checked by chasej@chromium.org

[commit-bot: I haz the power, 2016-04-12 19:12:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1872523003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1872523003/20001

[chasej, 2016-04-12 19:22:06]

On 2016/04/12 19:07:55, Rick Byers wrote:
> LGTM
> 
> Do we record metrics on how often this message is generated?  We want to
really
> avoid console spam, I'm kind of worried about the impact on this of code that
> does generic enumeration (eg. we've had this problem with deprecation messages
> on members of Event - it's very common for JS to blindly enumerate all Event
> member).  I think it's fine for now (no obvious general solution) but I would
> like to make sure we can tell if the occurrences of this warning skyrocket
> somehow.

I'm working on recording metrics for origin trial usage: crbug.com/587575. I've
added a note to that bug to ensure we have the appropriate metric(s) so we can
detect problems with console spam.

Note that we're also working on improving the bindings implementation:
crbug.com/584367. After consulting with the bindings team, we have an approach
that should completely hide interfaces/members that are not enabled, including
for generic iteration. We don't have a concrete timeline yet, as it partially
depends on some work from the bindings team.

Between the two above, we should be in good shape, although we aren't there yet.

[Rick Byers, 2016-04-12 19:34:25]

On 2016/04/12 19:22:06, chasej wrote:
> On 2016/04/12 19:07:55, Rick Byers wrote:
> > LGTM
> > 
> > Do we record metrics on how often this message is generated?  We want to
> really
> > avoid console spam, I'm kind of worried about the impact on this of code
that
> > does generic enumeration (eg. we've had this problem with deprecation
messages
> > on members of Event - it's very common for JS to blindly enumerate all Event
> > member).  I think it's fine for now (no obvious general solution) but I
would
> > like to make sure we can tell if the occurrences of this warning skyrocket
> > somehow.
> 
> I'm working on recording metrics for origin trial usage: crbug.com/587575.
I've
> added a note to that bug to ensure we have the appropriate metric(s) so we can
> detect problems with console spam.
> 
> Note that we're also working on improving the bindings implementation:
> crbug.com/584367. After consulting with the bindings team, we have an approach
> that should completely hide interfaces/members that are not enabled, including
> for generic iteration. We don't have a concrete timeline yet, as it partially
> depends on some work from the bindings team.
> 
> Between the two above, we should be in good shape, although we aren't there
yet.

Thanks for the details, sounds great to me!

[commit-bot: I haz the power, 2016-04-12 19:36:21]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-12 19:38:46]

Description was changed from

==========
Update error message with live URL for enabling trials

Update the message shown in the dev console to have a real URL. The URL
is https://bit.ly/OriginTrials, but isn't actually live yet. It will be
available soon, when a blog post is published.

BUG=590222
==========

to

==========
Update error message with live URL for enabling trials

Update the message shown in the dev console to have a real URL. The URL
is https://bit.ly/OriginTrials, but isn't actually live yet. It will be
available soon, when a blog post is published.

BUG=590222

Committed: https://crrev.com/f9499b969c76de97e6f85f54e73988b255ad64fa
Cr-Commit-Position: refs/heads/master@{#386762}
==========

[commit-bot: I haz the power, 2016-04-12 19:38:47]

Patchset 2 (id:??) landed as
https://crrev.com/f9499b969c76de97e6f85f54e73988b255ad64fa
Cr-Commit-Position: refs/heads/master@{#386762}