Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1872523002: give up if huge paths have unresolvable coincidence (Closed)

Created:
4 years, 8 months ago by hcm
Modified:
4 years, 8 months ago
Reviewers:
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@m50
Target Ref:
refs/heads/chrome/m50
Project:
skia
Visibility:
Public.

Description

give up if huge paths have unresolvable coincidence This fuzzy test has enormous curves with coincidence runs that break numerics. If the computed intersections identify that the span of coincidence has been deleted, give up and return that the path op failed. TBR=reed@google.com, caryclark@google.com BUG=597926 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1854333002 Review URL: https://codereview.chromium.org/1854333002 NOTREECHECKS=true NOTRY=true NOPRESUBMIT=true Committed: https://skia.googlesource.com/skia/+/f7c89fd393453407abf76175eabccd482ffc9ddf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -4 lines) Patch
M src/pathops/SkOpCoincidence.h View 1 chunk +1 line, -1 line 0 comments Download
M src/pathops/SkOpCoincidence.cpp View 2 chunks +9 lines, -2 lines 0 comments Download
M src/pathops/SkPathOpsCommon.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M tests/PathOpsOpTest.cpp View 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (7 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1872523002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1872523002/1
4 years, 8 months ago (2016-04-07 17:57:00 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-07 17:57:15 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/f7c89fd393453407abf76175eabccd482ffc9ddf

Powered by Google App Engine
This is Rietveld 408576698