Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1153)

Issue 1872513005: Add test for metrics invalidation on textnode removal (Closed)

Created:
4 years, 8 months ago by fs
Modified:
4 years, 8 months ago
Reviewers:
pdr.
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add test for metrics invalidation on textnode removal This tests that text metrics (read: collapsing info) are updated as needed when a text node is removed. BUG=299497, 594058 Committed: https://crrev.com/46068407adaa86bc96d8fffec53df7a0575cdcc9 Cr-Commit-Position: refs/heads/master@{#386223}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
A + third_party/WebKit/LayoutTests/svg/text/text-collapsed-ws-remove-textnode.html View 1 chunk +3 lines, -4 lines 0 comments Download
A third_party/WebKit/LayoutTests/svg/text/text-collapsed-ws-remove-textnode-expected.html View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
fs
To repeat what I wrote in (https://codereview.chromium.org/1865923002): "It passes with and without this CL, but ...
4 years, 8 months ago (2016-04-08 13:25:13 UTC) #2
pdr.
On 2016/04/08 at 13:25:13, fs wrote: > To repeat what I wrote in (https://codereview.chromium.org/1865923002): > ...
4 years, 8 months ago (2016-04-08 21:27:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1872513005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1872513005/1
4 years, 8 months ago (2016-04-08 22:07:25 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-08 22:13:31 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-08 22:15:32 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/46068407adaa86bc96d8fffec53df7a0575cdcc9
Cr-Commit-Position: refs/heads/master@{#386223}

Powered by Google App Engine
This is Rietveld 408576698