[compiler] Make OptimizedCompileJob agnostic from backend.

[compiler] Make OptimizedCompileJob agnostic from backend.

This refactors the OptimizedCompileJob class to be agnostic from the
actual underlying compiler. Instead it represents a base class for all
compilation jobs. The implementation is provided by the backend by just
overriding the phase methods.

Also note that this contains the semantics change of not falling back to
Crankshaft when TurboFan optimization fails. This fallback is no longer
needed and will not be supported going forward.

R=bmeurer@chromium.org

Committed: https://crrev.com/dea67cf0e3ed55e54c85ab6481b0f77a946dea6a
Cr-Commit-Position: refs/heads/master@{#35377}

[Michael Starzinger, 2016-04-07 16:38:20]

Description was changed from

==========
[compiler] Make OptimizedCompileJob agnostic from backend.

This refactors the OptimizedCompileJob class to be agnostic from the
actual underlying compiler. Instead it represents a base class for all
compilation jobs. The implementation is provided by the backend by just
overriding the phase methods.

Also not that this contains the semantics change of not falling back to
Crankshaft when TurboFan optimization fails. This fallback is no longer
needed and will not be supported going forward.

R=
==========

to

==========
[compiler] Make OptimizedCompileJob agnostic from backend.

This refactors the OptimizedCompileJob class to be agnostic from the
actual underlying compiler. Instead it represents a base class for all
compilation jobs. The implementation is provided by the backend by just
overriding the phase methods.

Also not that this contains the semantics change of not falling back to
Crankshaft when TurboFan optimization fails. This fallback is no longer
needed and will not be supported going forward.

R=bmeurer@chromium.org
==========

[Michael Starzinger, 2016-04-07 16:38:20]

mstarzinger@chromium.org changed reviewers:
+ bmeurer@chromium.org

[Michael Starzinger, 2016-04-07 16:38:59]

PTAL.

Note that I would like to do any renaming of existing classes and methods in a
separate CL. I actually have a couple of concrete renamings in mind already:
- OptimizedCompileJob -> CompilationJob
- CreateGraph -> PrepareJob
- OptimizeGraph -> ExecuteJob
- GenerateCode -> FinishJob

[Michael Starzinger, 2016-04-07 17:04:05]

Description was changed from

==========
[compiler] Make OptimizedCompileJob agnostic from backend.

This refactors the OptimizedCompileJob class to be agnostic from the
actual underlying compiler. Instead it represents a base class for all
compilation jobs. The implementation is provided by the backend by just
overriding the phase methods.

Also not that this contains the semantics change of not falling back to
Crankshaft when TurboFan optimization fails. This fallback is no longer
needed and will not be supported going forward.

R=bmeurer@chromium.org
==========

to

==========
[compiler] Make OptimizedCompileJob agnostic from backend.

This refactors the OptimizedCompileJob class to be agnostic from the
actual underlying compiler. Instead it represents a base class for all
compilation jobs. The implementation is provided by the backend by just
overriding the phase methods.

Also note that this contains the semantics change of not falling back to
Crankshaft when TurboFan optimization fails. This fallback is no longer
needed and will not be supported going forward.

R=bmeurer@chromium.org
==========

[Benedikt Meurer, 2016-04-08 04:21:41]

This is awesome! LGTM

[ahaas, 2016-04-08 12:24:38]

ahaas@chromium.org changed reviewers:
+ ahaas@chromium.org

[ahaas, 2016-04-08 12:24:39]

https://codereview.chromium.org/1872483002/diff/80001/src/compiler.h
File src/compiler.h (right):

https://codereview.chromium.org/1872483002/diff/80001/src/compiler.h#newcode571
src/compiler.h:571: // A base class for compilation jobs intended to concurrent
to the main thread.
intended to RUN concurrent ...

[Michael Starzinger, 2016-04-08 16:44:18]

Patchset #6 (id:100001) has been deleted

[Michael Starzinger, 2016-04-08 16:44:57]

https://codereview.chromium.org/1872483002/diff/80001/src/compiler.h
File src/compiler.h (right):

https://codereview.chromium.org/1872483002/diff/80001/src/compiler.h#newcode571
src/compiler.h:571: // A base class for compilation jobs intended to concurrent
to the main thread.
On 2016/04/08 12:24:39, ahaas wrote:
> intended to RUN concurrent ...

Done.

[Michael Starzinger, 2016-04-08 16:54:01]

Benedikt: Please confirm that it is OK to land with skipping mandreel.

https://codereview.chromium.org/1872483002/diff/140001/test/benchmarks/benchm...
File test/benchmarks/benchmarks.status (right):

https://codereview.chromium.org/1872483002/diff/140001/test/benchmarks/benchm...
test/benchmarks/benchmarks.status:32: 'octane/mandreel': [PASS, SLOW, ['mode ==
debug', SKIP], NO_VARIANTS],
As discussed offline: I had to disabled "mandreel" with TurboFan because it
causes a bailout in TurboFan and the missing fallback to Crankshaft now makes
several functions run in FullCodegen only. This leads to timeouts. I verified
that this is the bailout in simplified lowering (i.e.
SimplifiedLowering::abort_compilation) as we expected.

[Benedikt Meurer, 2016-04-08 17:40:11]

I'm fine with that. Jaro was already talking about a possible real fix for the
issue.

[Michael Starzinger, 2016-04-11 09:44:02]

The CQ bit was checked by mstarzinger@chromium.org

[Michael Starzinger, 2016-04-11 09:44:03]

The patchset sent to the CQ was uploaded after l-g-t-m from bmeurer@chromium.org
Link to the patchset: https://codereview.chromium.org/1872483002/#ps160001
(title: "Prevent endless recompile.")

[commit-bot: I haz the power, 2016-04-11 09:44:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1872483002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1872483002/160001

[commit-bot: I haz the power, 2016-04-11 10:01:15]

Description was changed from

==========
[compiler] Make OptimizedCompileJob agnostic from backend.

This refactors the OptimizedCompileJob class to be agnostic from the
actual underlying compiler. Instead it represents a base class for all
compilation jobs. The implementation is provided by the backend by just
overriding the phase methods.

Also note that this contains the semantics change of not falling back to
Crankshaft when TurboFan optimization fails. This fallback is no longer
needed and will not be supported going forward.

R=bmeurer@chromium.org
==========

to

==========
[compiler] Make OptimizedCompileJob agnostic from backend.

This refactors the OptimizedCompileJob class to be agnostic from the
actual underlying compiler. Instead it represents a base class for all
compilation jobs. The implementation is provided by the backend by just
overriding the phase methods.

Also note that this contains the semantics change of not falling back to
Crankshaft when TurboFan optimization fails. This fallback is no longer
needed and will not be supported going forward.

R=bmeurer@chromium.org
==========

[commit-bot: I haz the power, 2016-04-11 10:01:16]

Committed patchset #8 (id:160001)

[commit-bot: I haz the power, 2016-04-11 10:02:33]

Description was changed from

==========
[compiler] Make OptimizedCompileJob agnostic from backend.

This refactors the OptimizedCompileJob class to be agnostic from the
actual underlying compiler. Instead it represents a base class for all
compilation jobs. The implementation is provided by the backend by just
overriding the phase methods.

Also note that this contains the semantics change of not falling back to
Crankshaft when TurboFan optimization fails. This fallback is no longer
needed and will not be supported going forward.

R=bmeurer@chromium.org
==========

to

==========
[compiler] Make OptimizedCompileJob agnostic from backend.

This refactors the OptimizedCompileJob class to be agnostic from the
actual underlying compiler. Instead it represents a base class for all
compilation jobs. The implementation is provided by the backend by just
overriding the phase methods.

Also note that this contains the semantics change of not falling back to
Crankshaft when TurboFan optimization fails. This fallback is no longer
needed and will not be supported going forward.

R=bmeurer@chromium.org

Committed: https://crrev.com/dea67cf0e3ed55e54c85ab6481b0f77a946dea6a
Cr-Commit-Position: refs/heads/master@{#35377}
==========

[commit-bot: I haz the power, 2016-04-11 10:02:34]

Patchset 8 (id:??) landed as
https://crrev.com/dea67cf0e3ed55e54c85ab6481b0f77a946dea6a
Cr-Commit-Position: refs/heads/master@{#35377}