Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 1872463002: Remove IFX_AdditionalFontMgr and IFX_FontMgrDelegate. (Closed)

Created:
4 years, 8 months ago by dsinclair
Modified:
4 years, 8 months ago
Reviewers:
Tom Sepez, Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Remove IFX_AdditionalFontMgr and IFX_FontMgrDelegate. Neither are implemented. Removed. BUG=pdfium:468 Committed: https://pdfium.googlesource.com/pdfium/+/2d4a4fc372159ac7562abea48498b6ab72c2f321

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 2

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -140 lines) Patch
M core/fxge/include/fx_font.h View 1 chunk +0 lines, -9 lines 0 comments Download
M xfa/fgas/font/fgas_font.h View 1 2 3 4 5 chunks +13 lines, -40 lines 0 comments Download
M xfa/fgas/font/fgas_stdfontmgr.h View 1 2 3 4 7 chunks +18 lines, -24 lines 0 comments Download
M xfa/fgas/font/fgas_stdfontmgr.cpp View 1 2 3 4 14 chunks +40 lines, -67 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
dsinclair
PTAL. https://codereview.chromium.org/1872463002/diff/1/xfa/fgas/font/fgas_font.h File xfa/fgas/font/fgas_font.h (right): https://codereview.chromium.org/1872463002/diff/1/xfa/fgas/font/fgas_font.h#newcode159 xfa/fgas/font/fgas_font.h:159: static IFX_FontMgr* Create(FX_LPEnumAllFonts pEnumerator); As far as I ...
4 years, 8 months ago (2016-04-07 14:59:50 UTC) #2
Tom Sepez
lgtm https://codereview.chromium.org/1872463002/diff/60001/xfa/fgas/font/fgas_font.h File xfa/fgas/font/fgas_font.h (right): https://codereview.chromium.org/1872463002/diff/60001/xfa/fgas/font/fgas_font.h#newcode134 xfa/fgas/font/fgas_font.h:134: typedef FX_FONTDESCRIPTOR* FX_LPFONTDESCRIPTOR; nit: can we kill these ...
4 years, 8 months ago (2016-04-08 15:34:08 UTC) #5
dsinclair
https://codereview.chromium.org/1872463002/diff/60001/xfa/fgas/font/fgas_font.h File xfa/fgas/font/fgas_font.h (right): https://codereview.chromium.org/1872463002/diff/60001/xfa/fgas/font/fgas_font.h#newcode134 xfa/fgas/font/fgas_font.h:134: typedef FX_FONTDESCRIPTOR* FX_LPFONTDESCRIPTOR; On 2016/04/08 15:34:07, Tom Sepez wrote: ...
4 years, 8 months ago (2016-04-11 13:19:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1872463002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1872463002/80001
4 years, 8 months ago (2016-04-11 13:19:46 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-11 13:35:35 UTC) #11
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://pdfium.googlesource.com/pdfium/+/2d4a4fc372159ac7562abea48498b6ab72c2...

Powered by Google App Engine
This is Rietveld 408576698