Move MessageLocations constructor out of header

src/messages.h

 // Copyright 2006-2008 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // The infrastructure used for (localized) message reporting in V8.
 //
 // Note: there's a big unresolved issue about ownership of the data
 // structures used by this framework.
 
 #ifndef V8_MESSAGES_H_
 #define V8_MESSAGES_H_
 
 #include "src/base/smart-pointers.h"
 #include "src/handles.h"
 #include "src/list.h"
+#include "src/objects.h"
 
 namespace v8 {
 namespace internal {
 
 // Forward declarations.
 class JSMessageObject;
 class LookupIterator;
 class SourceInfo;
 
 class MessageLocation {
  public:
   MessageLocation(Handle<Script> script, int start_pos, int end_pos,

[Michael Starzinger, 2016/04/11 13:58:18]

If it is just this constructor that requires the include, then I would vote for
moving the constructor implementation into message.cc and forward declare the
necessary "class Script" and "class JSFunction" instead.

[Clemens Hammacher, 2016/04/11 14:08:47]

It's about the default constructor below, but yes, it probably makes more sense
to just move this constructor out of the header. I'll update the patch in a
second.

                   Handle<JSFunction> function = Handle<JSFunction>())
       : script_(script),
         start_pos_(start_pos),
         end_pos_(end_pos),
         function_(function) {}
   MessageLocation() : start_pos_(-1), end_pos_(-1) { }
 
   Handle<Script> script() const { return script_; }
   int start_pos() const { return start_pos_; }
   int end_pos() const { return end_pos_; }
@@ skipping 478 matching lines @@
   static Handle<String> GetMessage(Isolate* isolate, Handle<Object> data);
   static base::SmartArrayPointer<char> GetLocalizedMessage(Isolate* isolate,
                                                            Handle<Object> data);
 };
 
 
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_MESSAGES_H_