Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1872363004: cipd: accept a function in EnsureFile (Closed)

Created:
4 years, 8 months ago by nodir
Modified:
4 years, 8 months ago
Reviewers:
Vadim Sh.
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, andrew.wang, todd, tandrii+luci-go_chromium.org, M-A Ruel
Base URL:
https://chromium.googlesource.com/external/github.com/luci/luci-go@master
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

cipd: accept a function in EnsureFile Expose lower level API in FileSystem.EnsureFile R=vadimsh@chromium.org BUG=601017 Committed: https://github.com/luci/luci-go/commit/d91fccd83c7eff7aece07d5886a4ea2b2e9cc34b

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -27 lines) Patch
M client/cipd/client.go View 1 1 chunk +1 line, -1 line 0 comments Download
M client/cipd/local/deployer.go View 1 chunk +1 line, -1 line 0 comments Download
M client/cipd/local/fs.go View 6 chunks +26 lines, -18 lines 0 comments Download
M client/cipd/local/fs_test.go View 2 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
nodir
PTAL
4 years, 8 months ago (2016-04-11 22:17:46 UTC) #1
Vadim Sh.
lgtm
4 years, 8 months ago (2016-04-11 22:45:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1872363004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1872363004/1
4 years, 8 months ago (2016-04-13 23:25:00 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: Luci-go Linux Precise 32 Tester on master.tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Luci-go%20Linux%20Precise%2032%20Tester/builds/997) ...
4 years, 8 months ago (2016-04-13 23:26:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1872363004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1872363004/20001
4 years, 8 months ago (2016-04-13 23:27:40 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-13 23:31:40 UTC) #11
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://github.com/luci/luci-go/commit/d91fccd83c7eff7aece07d5886a4ea2b2e9cc34b

Powered by Google App Engine
This is Rietveld 408576698