Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 1872333002: [turbofan] Remove support for --turbo-types. (Closed)

Created:
4 years, 8 months ago by Benedikt Meurer
Modified:
4 years, 8 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Remove support for --turbo-types. We had exactly one test case for --noturbo-types, so it's likely that the generic pipeline (without types) was already broken for quite some time, plus no one expressed interest in maintaining it, plus it complicates the JSGenericLowering integration. So decision is to kill it. R=jarin@chromium.org Committed: https://crrev.com/086bc49894990505e6e3cef97cff16e1ded7f9a0 Cr-Commit-Position: refs/heads/master@{#35387}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -134 lines) Patch
M src/compiler.h View 2 chunks +6 lines, -11 lines 0 comments Download
M src/compiler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/js-generic-lowering.h View 2 chunks +1 line, -2 lines 0 comments Download
M src/compiler/js-generic-lowering.cc View 2 chunks +1 line, -17 lines 0 comments Download
M src/compiler/pipeline.cc View 5 chunks +37 lines, -46 lines 0 comments Download
M src/compiler/wasm-compiler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/cctest.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/compiler/function-tester.h View 2 chunks +1 line, -4 lines 0 comments Download
D test/cctest/compiler/test-pipeline.cc View 1 chunk +0 lines, -44 lines 0 comments Download
M test/cctest/compiler/test-run-inlining.cc View 1 chunk +2 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
4 years, 8 months ago (2016-04-11 12:33:17 UTC) #1
Benedikt Meurer
Hey Jaro, As discussed, this drops the "generic" (untyped) pipeline support. Please take a look. ...
4 years, 8 months ago (2016-04-11 12:34:19 UTC) #2
Jarin
lgtm
4 years, 8 months ago (2016-04-11 12:39:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1872333002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1872333002/1
4 years, 8 months ago (2016-04-11 12:39:49 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-11 12:56:53 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-11 12:57:36 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/086bc49894990505e6e3cef97cff16e1ded7f9a0
Cr-Commit-Position: refs/heads/master@{#35387}

Powered by Google App Engine
This is Rietveld 408576698