tools/android/loading/common_util.py - Issue 1872313002: sandwich: Implement SandwichTaskBuilder

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/android/loading/common_util.py

Issue 1872313002: sandwich: Implement SandwichTaskBuilder (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addresses pasko's comments and adds support for the different sub-resources discovrers Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/android/loading/common_util.py

diff --git a/tools/android/loading/common_util.py b/tools/android/loading/common_util.py

index 855284fdcf5761b43190047ac6ae5440cb1614f8..ed5c997e55662a9f304ad240f64ce41e446ad2cc 100644

--- a/tools/android/loading/common_util.py

+++ b/tools/android/loading/common_util.py

@@ -89,3 +89,10 @@ def TemporaryDirectory():

yield name

finally:

shutil.rmtree(name)

+def VerifyOrCreateParentDirectory(path):

pasko 2016/04/14 12:34:42 nit: usually when I saw things like that they were

gabadie 2016/04/14 15:43:32 Done.

+ """Verifies that the parent directory exists or create it if missing."""

pasko 2016/04/14 12:34:42 s/create/creates/

gabadie 2016/04/14 15:43:32 Done.

+ parent_directory_path = os.path.abspath(os.path.dirname(path))

+ if not os.path.isdir(parent_directory_path):

+ os.makedirs(parent_directory_path)

« no previous file with comments | « no previous file | tools/android/loading/sandwich.py » ('j') | tools/android/loading/sandwich.py » ('J')