third_party/WebKit/Source/core/html/HTMLSlotElement.h - Issue 1872303002: Simplify slot assignments

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLSlotElement.h

Issue 1872303002: Simplify slot assignments (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/dom/Node.cpp ('K') | « third_party/WebKit/Source/core/dom/shadow/SlotAssignment.cpp ('k') | third_party/WebKit/Source/core/html/HTMLSlotElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLSlotElement.h

diff --git a/third_party/WebKit/Source/core/html/HTMLSlotElement.h b/third_party/WebKit/Source/core/html/HTMLSlotElement.h

index 0812c46278438b7c853e8b3c2159ae73948d36fe..90b0c95ef15722dce960590f8bca0431745c32ae 100644

--- a/third_party/WebKit/Source/core/html/HTMLSlotElement.h

+++ b/third_party/WebKit/Source/core/html/HTMLSlotElement.h

@@ -53,6 +53,8 @@ public:

Node* distributedNodeNextTo(const Node&) const;

Node* distributedNodePreviousTo(const Node&) const;

+ AtomicString normalizedSlotName() const;

kochi 2016/04/11 10:57:54 No user of this function? I don't find the impleme

hayato 2016/04/12 04:06:53 Nice catch. Removed.

void appendAssignedNode(Node&);

void appendDistributedNode(Node&);

void appendDistributedNodesFrom(const HTMLSlotElement& other);

@@ -69,6 +71,7 @@ public:

void attributeChanged(const QualifiedName&, const AtomicString& oldValue, const AtomicString& newValue, AttributeModificationReason = ModifiedDirectly) final;

short tabIndex() const override;

+ AtomicString name() const;

DECLARE_VIRTUAL_TRACE();