Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1872253004: Revert of Pass effects directly to fontcache (Closed)

Created:
4 years, 8 months ago by borenet
Modified:
4 years, 8 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Pass effects directly to fontcache (patchset #8 id:140001 of https://codereview.chromium.org/1863013003/ ) Reason for revert: Seems to have broken the DEPS roll. Original issue's description: > Pass effects directly to fontcache > > BUG=skia:5176 > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1863013003 > > Committed: https://skia.googlesource.com/skia/+/c79172857c3f69cc46837e1beeae0c1ead377bb2 TBR=djsollen@google.com,bungeman@google.com,mtklein@google.com,fmalita@chromium.org,msarett@google.com,reed@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:5176 Committed: https://skia.googlesource.com/skia/+/25e0a0416e5b37c1e0bef1934dc67ff62e442916

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+173 lines, -212 lines) Patch
M include/core/SkPaint.h View 3 chunks +2 lines, -5 lines 0 comments Download
M include/core/SkTypeface.h View 5 chunks +4 lines, -4 lines 0 comments Download
M src/core/SkGlyphCache.h View 3 chunks +5 lines, -7 lines 0 comments Download
M src/core/SkGlyphCache.cpp View 2 chunks +5 lines, -6 lines 0 comments Download
M src/core/SkPaint.cpp View 6 chunks +13 lines, -18 lines 0 comments Download
M src/core/SkScalerContext.h View 4 chunks +9 lines, -21 lines 0 comments Download
M src/core/SkScalerContext.cpp View 7 chunks +37 lines, -18 lines 0 comments Download
M src/core/SkTypeface.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M src/fonts/SkGScalerContext.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/fonts/SkGScalerContext.cpp View 3 chunks +40 lines, -36 lines 0 comments Download
M src/fonts/SkRandomScalerContext.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/fonts/SkRandomScalerContext.cpp View 3 chunks +7 lines, -10 lines 0 comments Download
M src/fonts/SkTestScalerContext.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/fonts/SkTestScalerContext.cpp View 2 chunks +5 lines, -7 lines 0 comments Download
M src/gpu/GrPathRendering.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/GrPathRendering.cpp View 4 chunks +4 lines, -9 lines 0 comments Download
M src/gpu/GrResourceProvider.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/GrResourceProvider.cpp View 1 chunk +2 lines, -4 lines 0 comments Download
M src/gpu/text/GrAtlasTextBlob.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/text/GrAtlasTextBlob.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/text/GrAtlasTextBlob_regenInBatch.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/text/GrStencilAndCoverTextContext.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M src/gpu/text/GrTextUtils.cpp View 1 chunk +2 lines, -4 lines 0 comments Download
M src/ports/SkFontHost_FreeType.cpp View 3 chunks +6 lines, -8 lines 0 comments Download
M src/ports/SkFontHost_FreeType_common.h View 2 chunks +4 lines, -5 lines 0 comments Download
M src/ports/SkFontHost_mac.cpp View 4 chunks +5 lines, -8 lines 0 comments Download
M src/ports/SkFontHost_win.cpp View 4 chunks +6 lines, -10 lines 0 comments Download
M src/ports/SkScalerContext_win_dw.h View 1 chunk +1 line, -1 line 0 comments Download
M src/ports/SkScalerContext_win_dw.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/ports/SkTypeface_win_dw.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/ports/SkTypeface_win_dw.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M tests/FontMgrTest.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
borenet
Created Revert of Pass effects directly to fontcache
4 years, 8 months ago (2016-04-11 17:25:11 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1872253004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1872253004/1
4 years, 8 months ago (2016-04-11 17:25:16 UTC) #2
commit-bot: I haz the power
4 years, 8 months ago (2016-04-11 17:25:33 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/25e0a0416e5b37c1e0bef1934dc67ff62e442916

Powered by Google App Engine
This is Rietveld 408576698