Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Unified Diff: ui/file_manager/file_manager/foreground/js/file_manager_commands.js

Issue 1872223002: Add verbs API to file handlers. Modify the Chrome OS UI so that it displayes the internationalized … (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix comments mentioned by fukino@. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/file_manager/file_manager/foreground/js/file_manager_commands.js
diff --git a/ui/file_manager/file_manager/foreground/js/file_manager_commands.js b/ui/file_manager/file_manager/foreground/js/file_manager_commands.js
index d577d1e8b62a921d0c35f96f990a693506891df7..35bfe417bc1b70faf5ab1e7c1039bab55007a059 100644
--- a/ui/file_manager/file_manager/foreground/js/file_manager_commands.js
+++ b/ui/file_manager/file_manager/foreground/js/file_manager_commands.js
@@ -1025,7 +1025,7 @@ CommandHandler.COMMANDS_['default-task'] = /** @type {Command} */ ({
* Displays open with dialog for current selection.
* @type {Command}
*/
-CommandHandler.COMMANDS_['open-with'] = /** @type {Command} */ ({
+CommandHandler.COMMANDS_['more-actions'] = /** @type {Command} */ ({
/**
* @param {!Event} event Command event.
* @param {!FileManager} fileManager FileManager to use.
@@ -1033,7 +1033,7 @@ CommandHandler.COMMANDS_['open-with'] = /** @type {Command} */ ({
execute: function(event, fileManager) {
fileManager.taskController.getFileTasks().then(function(tasks) {
tasks.showTaskPicker(fileManager.ui.defaultTaskPicker,
- str('OPEN_WITH_BUTTON_LABEL'),
+ str('MORE_ACTIONS_BUTTON_LABEL'),
'',
function(task) {
tasks.execute(task.taskId);
@@ -1050,7 +1050,7 @@ CommandHandler.COMMANDS_['open-with'] = /** @type {Command} */ ({
* @param {!FileManager} fileManager FileManager to use.
*/
canExecute: function(event, fileManager) {
- var canExecute = fileManager.taskController.canExecuteOpenWith();
+ var canExecute = fileManager.taskController.canExecuteMoreActions();
event.canExecute = canExecute;
event.command.setHidden(!canExecute);
}

Powered by Google App Engine
This is Rietveld 408576698