Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(741)

Unified Diff: extensions/common/manifest_handlers/file_handler_manifest_unittest.cc

Issue 1872223002: Add verbs API to file handlers. Modify the Chrome OS UI so that it displayes the internationalized … (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Move back to "open-with" for the id of the more actions dialog, as it breaks some browsers tests, a… Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/common/manifest_handlers/file_handler_manifest_unittest.cc
diff --git a/extensions/common/manifest_handlers/file_handler_manifest_unittest.cc b/extensions/common/manifest_handlers/file_handler_manifest_unittest.cc
index d55c14848be2632af82ea5a5b87d0659fc25f222..6031849e1e17caac08bfd4cff32ca1de04f73c4c 100644
--- a/extensions/common/manifest_handlers/file_handler_manifest_unittest.cc
+++ b/extensions/common/manifest_handlers/file_handler_manifest_unittest.cc
@@ -16,20 +16,22 @@ typedef ManifestTest FileHandlersManifestTest;
TEST_F(FileHandlersManifestTest, InvalidFileHandlers) {
Testcase testcases[] = {
- Testcase("file_handlers_invalid_handlers.json",
- errors::kInvalidFileHandlers),
- Testcase("file_handlers_invalid_type.json",
- errors::kInvalidFileHandlerType),
- Testcase("file_handlers_invalid_extension.json",
- errors::kInvalidFileHandlerExtension),
- Testcase("file_handlers_invalid_no_type_or_extension.json",
- errors::kInvalidFileHandlerNoTypeOrExtension),
- Testcase("file_handlers_invalid_type_element.json",
- errors::kInvalidFileHandlerTypeElement),
- Testcase("file_handlers_invalid_extension_element.json",
- errors::kInvalidFileHandlerExtensionElement),
- Testcase("file_handlers_invalid_too_many.json",
- errors::kInvalidFileHandlersTooManyTypesAndExtensions),
+ Testcase("file_handlers_invalid_handlers.json",
+ errors::kInvalidFileHandlers),
+ Testcase("file_handlers_invalid_type.json",
+ errors::kInvalidFileHandlerType),
+ Testcase("file_handlers_invalid_extension.json",
+ errors::kInvalidFileHandlerExtension),
+ Testcase("file_handlers_invalid_no_type_or_extension.json",
+ errors::kInvalidFileHandlerNoTypeOrExtension),
+ Testcase("file_handlers_invalid_type_element.json",
+ errors::kInvalidFileHandlerTypeElement),
+ Testcase("file_handlers_invalid_extension_element.json",
+ errors::kInvalidFileHandlerExtensionElement),
+ Testcase("file_handlers_invalid_too_many.json",
+ errors::kInvalidFileHandlersTooManyTypesAndExtensions),
+ Testcase("file_handlers_invalid_verb.json",
+ errors::kInvalidFileHandlerVerb),
};
RunTestcases(testcases, arraysize(testcases), EXPECT_TYPE_ERROR);
}
@@ -51,6 +53,7 @@ TEST_F(FileHandlersManifestTest, ValidFileHandlers) {
EXPECT_EQ(2U, handler.extensions.size());
EXPECT_EQ(1U, handler.extensions.count(".png"));
EXPECT_EQ(1U, handler.extensions.count(".gif"));
+ EXPECT_EQ("add_to", handler.verb);
handler = handlers->at(1);
EXPECT_EQ("text", handler.id);

Powered by Google App Engine
This is Rietveld 408576698