Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3363)

Unified Diff: chrome/browser/chromeos/file_manager/arc_file_tasks.cc

Issue 1872223002: Add verbs API to file handlers. Modify the Chrome OS UI so that it displayes the internationalized … (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Move back to "open-with" for the id of the more actions dialog, as it breaks some browsers tests, a… Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/file_manager/arc_file_tasks.cc
diff --git a/chrome/browser/chromeos/file_manager/arc_file_tasks.cc b/chrome/browser/chromeos/file_manager/arc_file_tasks.cc
index 7bae42d3ac1e2833a9943135d17a921144b15e2f..12c311a2a3e98d0e367a72d5b36c3ad5fcafa6ea 100644
--- a/chrome/browser/chromeos/file_manager/arc_file_tasks.cc
+++ b/chrome/browser/chromeos/file_manager/arc_file_tasks.cc
@@ -23,7 +23,6 @@
#include "mojo/public/cpp/bindings/binding.h"
#include "net/base/filename_util.h"
#include "storage/browser/fileapi/file_system_url.h"
-#include "ui/base/l10n/l10n_util.h"
#include "url/gurl.h"
namespace file_manager {
@@ -137,19 +136,19 @@ void OnArcHandlerList(
std::unique_ptr<std::vector<FullTaskDescriptor>> result_list,
const FindTasksCallback& callback,
mojo::Array<arc::mojom::UrlHandlerInfoPtr> handlers) {
+ using extensions::api::file_manager_private::Verb;
for (const arc::mojom::UrlHandlerInfoPtr& handler : handlers) {
- // TODO(crbug.com/578725): Wire action to "verb" once it's implemented.
std::string name(handler->name);
+ Verb handler_verb = Verb::VERB_NONE;
if (handler->action == arc::mojom::ActionType::SEND ||
handler->action == arc::mojom::ActionType::SEND_MULTIPLE) {
- name = l10n_util::GetStringFUTF8(IDS_FILE_BROWSER_SHARE_WITH_ACTION_LABEL,
- base::UTF8ToUTF16(name));
+ handler_verb = Verb::VERB_SHARE_WITH;
}
result_list->push_back(FullTaskDescriptor(
TaskDescriptor(
ActivityNameToAppId(handler->package_name, handler->activity_name),
TASK_TYPE_ARC_APP, ArcActionToString(handler->action)),
- name,
+ handler->name, handler_verb,
GURL(""), // TODO: get the icon
false, // is_default,
handler->action != arc::mojom::ActionType::VIEW // is_generic

Powered by Google App Engine
This is Rietveld 408576698