Add verbs API to file handlers. Modify the Chrome OS UI so that it displayes the internationalized …

chrome/browser/chromeos/extensions/file_manager/private_api_tasks.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/extensions/file_manager/private_api_tasks.h"
 
 #include <stddef.h>
 
 #include <set>
 #include <string>
 #include <vector>
 
+#include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/chromeos/drive/file_system_util.h"
 #include "chrome/browser/chromeos/file_manager/fileapi_util.h"
 #include "chrome/browser/chromeos/fileapi/file_system_backend.h"
 #include "chrome/browser/extensions/api/file_handlers/directory_util.h"
 #include "chrome/browser/extensions/api/file_handlers/mime_util.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/common/extensions/api/file_manager_private.h"
 #include "chrome/common/extensions/api/file_manager_private_internal.h"
 #include "content/public/browser/browser_thread.h"
 #include "extensions/browser/entry_info.h"
@@ skipping 167 matching lines @@
 
   // Convert the tasks into JSON compatible objects.
   using api::file_manager_private::FileTask;
   std::vector<FileTask> results;
   for (const file_manager::file_tasks::FullTaskDescriptor& task : tasks) {
     FileTask converted;
     converted.task_id =
         file_manager::file_tasks::TaskDescriptorToId(task.task_descriptor());
     if (!task.icon_url().is_empty())
       converted.icon_url = task.icon_url().spec();
-    converted.title = task.task_title();
+    // TODO(cmihail): Does this conversion really work?
+    converted.title = base::UTF16ToUTF8(task.task_title());

[fukino, 2016/04/11 09:19:43]

Just a question: Why should be convert task title from UTF8 to UTF16?
(I'm concerned about that it has been broken, or we need to do so from this
patch?)

[cmihail, 2016/04/13 07:36:46]

Unfortunately IDL doesn't allow me to pass a UTF16 string to JS, or at least I
don't know how to do it. This is what I left the TODO for.

The idea is that for simplicity I did the internationalization of the verbs in
C++ code (in the JS is a bit more complicated), but I can switch to that one if
better. Or use a proper technique to pass the C++ internationalization to JS if
possible, though unsure what is the correct way.

[fukino, 2016/04/13 08:03:12]

Sorry! I'm not familiar with internationalization in C++ side.
+mtomasz@chromium.org, is there a standard way to do the internationalization in
C++ side?

[mtomasz, 2016/04/13 09:17:06]

I think internationalization in C++ is OK.

     converted.is_default = task.is_default();
     converted.is_generic_file_handler = task.is_generic_file_handler();
     results.push_back(std::move(converted));
   }
 
   results_ = extensions::api::file_manager_private_internal::GetFileTasks::
       Results::Create(results);
   SendResponse(true);
 }
 
@@ skipping 21 matching lines @@
     SetResult(new base::FundamentalValue(true));
     return true;
   }
 
   file_manager::file_tasks::UpdateDefaultTask(
       GetProfile()->GetPrefs(), params->task_id, suffixes, mime_types);
   return true;
 }
 
 }  // namespace extensions