Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/profiler/strings-storage.h

Issue 1872203005: Fix printf formats (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix unused param found by GC mole Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/profiler/profile-generator.cc ('k') | src/snapshot/serializer.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_PROFILER_STRINGS_STORAGE_H_ 5 #ifndef V8_PROFILER_STRINGS_STORAGE_H_
6 #define V8_PROFILER_STRINGS_STORAGE_H_ 6 #define V8_PROFILER_STRINGS_STORAGE_H_
7 7
8 #include "src/allocation.h" 8 #include "src/allocation.h"
9 #include "src/base/compiler-specific.h"
9 #include "src/hashmap.h" 10 #include "src/hashmap.h"
10 11
11 namespace v8 { 12 namespace v8 {
12 namespace internal { 13 namespace internal {
13 14
14 // Provides a storage of strings allocated in C++ heap, to hold them 15 // Provides a storage of strings allocated in C++ heap, to hold them
15 // forever, even if they disappear from JS heap or external storage. 16 // forever, even if they disappear from JS heap or external storage.
16 class StringsStorage { 17 class StringsStorage {
17 public: 18 public:
18 explicit StringsStorage(Heap* heap); 19 explicit StringsStorage(Heap* heap);
19 ~StringsStorage(); 20 ~StringsStorage();
20 21
21 const char* GetCopy(const char* src); 22 const char* GetCopy(const char* src);
22 const char* GetFormatted(const char* format, ...); 23 PRINTF_FORMAT(2, 3) const char* GetFormatted(const char* format, ...);
24 PRINTF_FORMAT(2, 0)
23 const char* GetVFormatted(const char* format, va_list args); 25 const char* GetVFormatted(const char* format, va_list args);
24 const char* GetName(Name* name); 26 const char* GetName(Name* name);
25 const char* GetName(int index); 27 const char* GetName(int index);
26 const char* GetFunctionName(Name* name); 28 const char* GetFunctionName(Name* name);
27 const char* GetFunctionName(const char* name); 29 const char* GetFunctionName(const char* name);
28 size_t GetUsedMemorySize() const; 30 size_t GetUsedMemorySize() const;
29 31
30 private: 32 private:
31 static const int kMaxNameSize = 1024; 33 static const int kMaxNameSize = 1024;
32 34
33 static bool StringsMatch(void* key1, void* key2); 35 static bool StringsMatch(void* key1, void* key2);
34 const char* AddOrDisposeString(char* str, int len); 36 const char* AddOrDisposeString(char* str, int len);
35 HashMap::Entry* GetEntry(const char* str, int len); 37 HashMap::Entry* GetEntry(const char* str, int len);
36 38
37 uint32_t hash_seed_; 39 uint32_t hash_seed_;
38 HashMap names_; 40 HashMap names_;
39 41
40 DISALLOW_COPY_AND_ASSIGN(StringsStorage); 42 DISALLOW_COPY_AND_ASSIGN(StringsStorage);
41 }; 43 };
42 } // namespace internal 44 } // namespace internal
43 } // namespace v8 45 } // namespace v8
44 46
45 #endif // V8_PROFILER_STRINGS_STORAGE_H_ 47 #endif // V8_PROFILER_STRINGS_STORAGE_H_
OLDNEW
« no previous file with comments | « src/profiler/profile-generator.cc ('k') | src/snapshot/serializer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698