Graduate matrix map-point procs out of SkOpts.

Graduate matrix map-point procs out of SkOpts.

These are implemented generically with Sk4s and don't benefit
from anything fancier than vanilla SSE/NEON.

This means there's no need to hide this code away in another
file or behind a function pointer... it's readable and we have
compile-time support for all the instructions it needs.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1872193002
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot

Committed: https://skia.googlesource.com/skia/+/567118fbe69f9d0e245ddc0a6c312b6b9b70233f

[mtklein_C, 2016-04-10 14:04:46]

Description was changed from

==========
Graduate matrix map-point procs out of SkOpts.

They don't benefit from anything fancier than vanilla SSE/NEON.

This means we've got all their instructions at compile time now;
no need to hide them behind a function pointer indirection.

BUG=skia:
==========

to

==========
Graduate matrix map-point procs out of SkOpts.

They don't benefit from anything fancier than vanilla SSE/NEON.

This means we've got all their instructions at compile time now;
no need to hide them behind a function pointer indirection.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
==========

[mtklein_C, 2016-04-10 14:09:13]

Description was changed from

==========
Graduate matrix map-point procs out of SkOpts.

They don't benefit from anything fancier than vanilla SSE/NEON.

This means we've got all their instructions at compile time now;
no need to hide them behind a function pointer indirection.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
==========

to

==========
Graduate matrix map-point procs out of SkOpts.

These are implemented generically in Sk4s and don't benefit
from anything fancier than vanilla SSE/NEON.

This means there's no need to hide this code away in another
file or behind a function pointer... it's readable and we have
support for all the instructions it needs at compile time.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
==========

[mtklein_C, 2016-04-10 14:09:53]

Description was changed from

==========
Graduate matrix map-point procs out of SkOpts.

These are implemented generically in Sk4s and don't benefit
from anything fancier than vanilla SSE/NEON.

This means there's no need to hide this code away in another
file or behind a function pointer... it's readable and we have
support for all the instructions it needs at compile time.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
==========

to

==========
Graduate matrix map-point procs out of SkOpts.

These are implemented generically in Sk4s and don't benefit
from anything fancier than vanilla SSE/NEON.

This means there's no need to hide this code away in another
file or behind a function pointer... it's readable and we have
compile-time support for all the instructions it needs.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
==========

[mtklein_C, 2016-04-10 14:10:29]

Description was changed from

==========
Graduate matrix map-point procs out of SkOpts.

These are implemented generically in Sk4s and don't benefit
from anything fancier than vanilla SSE/NEON.

This means there's no need to hide this code away in another
file or behind a function pointer... it's readable and we have
compile-time support for all the instructions it needs.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
==========

to

==========
Graduate matrix map-point procs out of SkOpts.

These are implemented generically with Sk4s and don't benefit
from anything fancier than vanilla SSE/NEON.

This means there's no need to hide this code away in another
file or behind a function pointer... it's readable and we have
compile-time support for all the instructions it needs.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
==========

[mtklein_C, 2016-04-10 14:10:33]

The CQ bit was checked by mtklein@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-10 14:10:46]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1872193002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1872193002/20001

[commit-bot: I haz the power, 2016-04-10 14:11:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-10 14:11:50]

Dry run: Try jobs failed on following builders:
  Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot on client.skia.compile
(JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...)

[mtklein_C, 2016-04-10 14:17:02]

The CQ bit was checked by mtklein@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-10 14:17:18]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1872193002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1872193002/40001

[commit-bot: I haz the power, 2016-04-10 14:27:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-10 14:27:02]

Dry run: This issue passed the CQ dry run.

[mtklein_C, 2016-04-14 19:37:27]

mtklein@chromium.org changed reviewers:
+ reed@google.com

[mtklein_C, 2016-04-14 19:37:27]

Was going to ping this CL, then I noticed I never sent it to you the first time.
 Whoops!

[reed1, 2016-04-14 20:02:06]

I presume the nanobench timings are unchanged (or improved)

lgtm

[mtklein, 2016-04-14 20:41:32]

On 2016/04/14 at 20:02:06, reed wrote:
> I presume the nanobench timings are unchanged (or improved)
> 
> lgtm

Yes, somewhere between unchanged and improved by an uninteresting amount.

[mtklein, 2016-04-14 20:41:36]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2016-04-14 20:41:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1872193002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1872193002/40001

[commit-bot: I haz the power, 2016-04-14 21:07:04]

Description was changed from

==========
Graduate matrix map-point procs out of SkOpts.

These are implemented generically with Sk4s and don't benefit
from anything fancier than vanilla SSE/NEON.

This means there's no need to hide this code away in another
file or behind a function pointer... it's readable and we have
compile-time support for all the instructions it needs.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
==========

to

==========
Graduate matrix map-point procs out of SkOpts.

These are implemented generically with Sk4s and don't benefit
from anything fancier than vanilla SSE/NEON.

This means there's no need to hide this code away in another
file or behind a function pointer... it's readable and we have
compile-time support for all the instructions it needs.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot

Committed:
https://skia.googlesource.com/skia/+/567118fbe69f9d0e245ddc0a6c312b6b9b70233f
==========

[commit-bot: I haz the power, 2016-04-14 21:07:06]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/567118fbe69f9d0e245ddc0a6c312b6b9b70233f