Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1224)

Issue 1872143002: [turbofan] Improve lowering of ObjectIs<Type> somewhat. (Closed)

Created:
4 years, 8 months ago by Benedikt Meurer
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Improve lowering of ObjectIs<Type> somewhat. If we already know that the input to one of the ObjectIs<Type> nodes is TaggedPointer, we don't need to perform the Smi check at runtime. R=jarin@chromium.org Committed: https://crrev.com/4fc4978cee0bb7ad2ae8681a67b7032eba6a7d11 Cr-Commit-Position: refs/heads/master@{#35368}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -50 lines) Patch
M src/compiler/change-lowering.cc View 1 chunk +85 lines, -50 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Benedikt Meurer
4 years, 8 months ago (2016-04-09 17:10:07 UTC) #1
Benedikt Meurer
Hey Jaro, Simple improvement, helps Richards. Please take a look. Thanks, Benedikt
4 years, 8 months ago (2016-04-09 17:55:17 UTC) #2
Jarin
lgtm
4 years, 8 months ago (2016-04-10 10:09:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1872143002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1872143002/1
4 years, 8 months ago (2016-04-10 15:14:05 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-10 15:31:08 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4fc4978cee0bb7ad2ae8681a67b7032eba6a7d11 Cr-Commit-Position: refs/heads/master@{#35368}
4 years, 8 months ago (2016-04-10 15:31:48 UTC) #8
Benedikt Meurer
4 years, 8 months ago (2016-04-16 19:00:35 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1893123002/ by bmeurer@chromium.org.

The reason for reverting is: Looking at types in ChangeLowering is generally
unsafe..

Powered by Google App Engine
This is Rietveld 408576698