Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 1872133002: Revert of Reland: Switch components/password_manager code from IPC messages to Mojo. (Closed)

Created:
4 years, 8 months ago by fs
Modified:
4 years, 8 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, blundell+watchlist_chromium.org, chromium-reviews, darin (slow to review), darin-cc_chromium.org, droger+watchlist_chromium.org, gcasto+watchlist_chromium.org, jam, mkwst+watchlist-passwords_chromium.org, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, qsr+mojo_chromium.org, sdefresne+watchlist_chromium.org, sdefresne+watch_chromium.org, vabr+watchlistpasswordmanager_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Reland: Switch components/password_manager code from IPC messages to Mojo. (patchset #4 id:60001 of https://codereview.chromium.org/1866643002/ ) Reason for revert: Appears to have caused: FAILED: /b/build/slave/GPU_Linux_Builder/build/src/build/goma/client/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/chrome/browser/test_support_ui/password_manager_test_base.o.d -DV8_DEPRECATION_WARNINGS -DCLD_VERSION=2 -DENABLE_MDNS=1 -DENABLE_NOTIFICATIONS -DENABLE_PEPPER_CDMS -DENABLE_PLUGINS=1 -DENABLE_PDF=1 -DENABLE_PRINTING=1 -DENABLE_BASIC_PRINTING=1 -DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1 -DUSE_UDEV -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1 -DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_CLIPBOARD_AURAX11=1 -DUSE_DEFAULT_RENDER_THEME=1 -DUSE_GLIB=1 -DUSE_OPENSSL=1 -DUSE_NSS_CERTS=1 -DUSE_NSS_VERIFIER=1 -DUSE_X11=1 -DENABLE_WEBRTC=1 -DENABLE_EXTENSIONS=1 -DENABLE_TASK_MANAGER=1 -DENABLE_THEMES=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1 -DENABLE_SUPERVISED_USERS=1 -DENABLE_SERVICE_DISCOVERY=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_TOPCHROME_MD=1 -DUSE_PROPRIETARY_CODECS -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DENABLE_MEDIA_ROUTER=1 -DFIELDTRIAL_TESTING_ENABLED -DCR_CLANG_REVISION=264915-1 -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DTOOLKIT_VIEWS=1 -DGL_GLEXT_PROTOTYPES -DGTEST_HAS_POSIX_RE=0 -DGTEST_LANG_CXX11=0 -DGTEST_HAS_RTTI=0 -DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS -DSK_SUPPORT_GPU=1 -DUNIT_TEST -I../.. -Igen -I../../build/linux/debian_wheezy_amd64-sysroot/usr/include/glib-2.0 -I../../build/linux/debian_wheezy_amd64-sysroot/usr/lib/x86_64-linux-gnu/glib-2.0/include -I../../third_party/protobuf/src -Igen/protoc_out -I../../third_party/protobuf/src -I../../third_party/protobuf -I../../third_party/khronos -I../../gpu -I../../testing/gtest/include -I../../build/linux/debian_wheezy_amd64-sysroot/usr/include/nss -I../../build/linux/debian_wheezy_amd64-sysroot/usr/include/nspr -I../../third_party/boringssl/src/include -I../../testing/gmock/include -I../../skia/config -I../../skia/ext -I../../third_party/skia/include/c -I../../third_party/skia/include/config -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/images -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pdf -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../third_party/skia/include/gpu -I../../third_party/skia/src/gpu -fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector -funwind-tables -fPIC -pipe -B../../third_party/binutils/Linux_x64/Release/bin -fcolor-diagnostics -fdebug-prefix-map=/b/build/slave/GPU_Linux_Builder/build/src=. -pthread -m64 -march=x86-64 -Wall -Werror -Wextra -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-deprecated-register -Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override -Wno-shift-negative-value -O2 -fno-ident -fdata-sections -ffunction-sections -g0 --sysroot=../../build/linux/debian_wheezy_amd64-sysroot -fvisibility=hidden -Xclang -load -Xclang ../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang -add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs -Xclang check-templates -Xclang -plugin-arg-find-bad-constructs -Xclang follow-macro-expansion -Wheader-hygiene -Wstring-conversion -Wno-header-guard -fno-threadsafe-statics -fvisibility-inlines-hidden -std=gnu++11 -fno-rtti -fno-exceptions -c ../../chrome/browser/password_manager/password_manager_test_base.cc -o obj/chrome/browser/test_support_ui/password_manager_test_base.o In file included from ../../chrome/browser/password_manager/password_manager_test_base.cc:13: In file included from ../../chrome/browser/password_manager/chrome_password_manager_client.h:15: In file included from ../../components/password_manager/content/browser/credential_manager_impl.h:13: In file included from gen/components/password_manager/content/public/interfaces/credential_manager.mojom.h:26: gen/components/password_manager/content/public/interfaces/credential_manager.mojom-internal.h:14:10: fatal error: 'url/mojo/origin.mojom-internal.h' file not found #include "url/mojo/origin.mojom-internal.h" (https://build.chromium.org/p/chromium.gpu/builders/GPU%20Linux%20Builder/builds/58271/steps/compile/logs/stdio) Original issue's description: > Reland: Switch components/password_manager code from IPC messages to Mojo. > > Original CL was found breaking android gn build after landed.. #strange > Fix BUILD.gn and reland. > > The original CL: > https://crrev.com/d20fb918841354a75546fa38b5307aaba117598b > > Original CL description follows: > > Replace credential_manager_messages.h IPC to Mojo service. > > BUG=582391 > > Committed: https://crrev.com/4a2f71f4c9e9e2c3ac0e4622c12e5dc0c5ebfe24 > Cr-Commit-Position: refs/heads/master@{#386290} TBR=jochen@chromium.org,amistry@chromium.org,rockot@chromium.org,tsepez@chromium.org,vabr@chromium.org,leon.han@intel.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=582391 Committed: https://crrev.com/f0def912cede308976fcc4fc7b0df5eed9b264aa Cr-Commit-Position: refs/heads/master@{#386297}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2112 lines, -2259 lines) Patch
M chrome/browser/chrome_content_browser_client.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M chrome/browser/password_manager/chrome_password_manager_client.h View 3 chunks +3 lines, -9 lines 0 comments Download
M chrome/browser/password_manager/chrome_password_manager_client.cc View 3 chunks +2 lines, -15 lines 0 comments Download
M chrome/browser/password_manager/chrome_password_manager_client_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_common.gypi View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/components_tests.gyp View 2 chunks +2 lines, -1 line 0 comments Download
M components/password_manager.gypi View 4 chunks +17 lines, -38 lines 0 comments Download
M components/password_manager/content/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M components/password_manager/content/browser/BUILD.gn View 3 chunks +4 lines, -6 lines 0 comments Download
M components/password_manager/content/browser/DEPS View 1 chunk +0 lines, -2 lines 0 comments Download
A components/password_manager/content/browser/credential_manager_dispatcher.h View 1 chunk +129 lines, -0 lines 0 comments Download
A components/password_manager/content/browser/credential_manager_dispatcher.cc View 1 chunk +292 lines, -0 lines 0 comments Download
A components/password_manager/content/browser/credential_manager_dispatcher_unittest.cc View 1 chunk +1191 lines, -0 lines 0 comments Download
D components/password_manager/content/browser/credential_manager_impl.h View 1 chunk +0 lines, -126 lines 0 comments Download
D components/password_manager/content/browser/credential_manager_impl.cc View 1 chunk +0 lines, -281 lines 0 comments Download
D components/password_manager/content/browser/credential_manager_impl_unittest.cc View 1 chunk +0 lines, -1149 lines 0 comments Download
A components/password_manager/content/common/BUILD.gn View 1 chunk +22 lines, -0 lines 0 comments Download
A components/password_manager/content/common/DEPS View 1 chunk +4 lines, -0 lines 0 comments Download
A components/password_manager/content/common/OWNERS View 1 chunk +13 lines, -0 lines 0 comments Download
A components/password_manager/content/common/credential_manager_content_utils.h View 1 chunk +22 lines, -0 lines 0 comments Download
A components/password_manager/content/common/credential_manager_content_utils.cc View 1 chunk +36 lines, -0 lines 0 comments Download
A components/password_manager/content/common/credential_manager_message_generator.h View 1 chunk +7 lines, -0 lines 0 comments Download
A components/password_manager/content/common/credential_manager_message_generator.cc View 1 chunk +33 lines, -0 lines 0 comments Download
A components/password_manager/content/common/credential_manager_messages.h View 1 chunk +86 lines, -0 lines 0 comments Download
D components/password_manager/content/public/cpp/BUILD.gn View 1 chunk +0 lines, -23 lines 0 comments Download
D components/password_manager/content/public/cpp/type_converters.h View 1 chunk +0 lines, -51 lines 0 comments Download
D components/password_manager/content/public/cpp/type_converters.cc View 1 chunk +0 lines, -128 lines 0 comments Download
D components/password_manager/content/public/interfaces/BUILD.gn View 1 chunk +0 lines, -17 lines 0 comments Download
D components/password_manager/content/public/interfaces/OWNERS View 1 chunk +0 lines, -13 lines 0 comments Download
D components/password_manager/content/public/interfaces/credential_manager.mojom View 1 chunk +0 lines, -44 lines 0 comments Download
M components/password_manager/content/renderer/BUILD.gn View 2 chunks +4 lines, -4 lines 0 comments Download
M components/password_manager/content/renderer/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M components/password_manager/content/renderer/credential_manager_client.h View 3 chunks +27 lines, -4 lines 0 comments Download
M components/password_manager/content/renderer/credential_manager_client.cc View 4 chunks +92 lines, -161 lines 0 comments Download
M components/password_manager/content/renderer/credential_manager_client_browsertest.cc View 5 chunks +92 lines, -120 lines 0 comments Download
M components/password_manager/core/browser/credential_manager_pending_request_task.h View 5 chunks +5 lines, -10 lines 0 comments Download
M components/password_manager/core/browser/credential_manager_pending_request_task.cc View 6 chunks +7 lines, -7 lines 0 comments Download
M components/password_manager/core/common/credential_manager_types.h View 2 chunks +1 line, -2 lines 0 comments Download
M components/password_manager/core/common/credential_manager_types.cc View 1 chunk +2 lines, -10 lines 0 comments Download
M content/content_common_mojo_bindings.gyp View 2 chunks +4 lines, -4 lines 0 comments Download
M ios/chrome/browser/passwords/credential_manager.h View 2 chunks +2 lines, -7 lines 0 comments Download
M ios/chrome/browser/passwords/credential_manager.mm View 6 chunks +7 lines, -15 lines 0 comments Download
M ipc/ipc_message_start.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
fs
Created Revert of Reland: Switch components/password_manager code from IPC messages to Mojo.
4 years, 8 months ago (2016-04-09 16:12:30 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1872133002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1872133002/1
4 years, 8 months ago (2016-04-09 16:12:36 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-09 16:13:42 UTC) #3
commit-bot: I haz the power
4 years, 8 months ago (2016-04-09 16:14:40 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f0def912cede308976fcc4fc7b0df5eed9b264aa
Cr-Commit-Position: refs/heads/master@{#386297}

Powered by Google App Engine
This is Rietveld 408576698