Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 1872073002: Code completion improvement in the DAS- only suggest completions on the RHS of an as-expression tha… (Closed)

Created:
4 years, 8 months ago by jwren
Modified:
4 years, 8 months ago
Reviewers:
danrubel
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Code completion improvement in the DAS- only suggest completions on the RHS of an as-expression that are proper subtypes of the type of the LHS of the as-expression. R=danrubel@google.com Committed: https://github.com/dart-lang/sdk/commit/8a9403e15c9c163fdabe96160e2ef15967f716c8

Patch Set 1 #

Patch Set 2 : rebase with bleeding_edge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -10 lines) Patch
M pkg/analysis_server/lib/src/services/completion/dart/optype.dart View 2 chunks +8 lines, -7 lines 0 comments Download
M pkg/analysis_server/test/completion_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/completion/dart/local_reference_contributor_test.dart View 3 chunks +34 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
jwren
4 years, 8 months ago (2016-04-08 22:58:15 UTC) #2
danrubel
LGTM
4 years, 8 months ago (2016-04-09 13:02:34 UTC) #3
jwren
Committed patchset #2 (id:20001) manually as 8a9403e15c9c163fdabe96160e2ef15967f716c8 (presubmit successful).
4 years, 8 months ago (2016-04-11 16:59:35 UTC) #5
jwren
4 years, 8 months ago (2016-04-11 17:03:38 UTC) #6
Message was sent while issue was closed.
On 2016/04/11 16:59:35, jwren wrote:
> Committed patchset #2 (id:20001) manually as
> 8a9403e15c9c163fdabe96160e2ef15967f716c8 (presubmit successful).

Landed, taking https://codereview.chromium.org/1876603002/ under advisement to
make as-expressions work for imported libraries (or add tests if your change
covers this case.)

Powered by Google App Engine
This is Rietveld 408576698