Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1145)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java

Issue 1872013002: Fix Android accessibility for editable text fields (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update test expectation Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java b/content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java
index 1ed5a3c3fbbe8f69106ce1cfb6cb6338fb793716..d7ff4d1501d6fd9e3c4cf0a0280810ac2a823232 100644
--- a/content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java
+++ b/content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java
@@ -854,14 +854,20 @@ public class BrowserAccessibilityManager {
@SuppressLint("NewApi")
@CalledByNative
- private void setAccessibilityNodeInfoContentDescription(
- AccessibilityNodeInfo node, String contentDescription, boolean annotateAsLink) {
+ private void setAccessibilityNodeInfoText(
+ AccessibilityNodeInfo node, String text, boolean annotateAsLink,
+ boolean isEditableText) {
+ CharSequence charSequence = text;
if (annotateAsLink) {
- SpannableString spannable = new SpannableString(contentDescription);
+ SpannableString spannable = new SpannableString(text);
spannable.setSpan(new URLSpan(""), 0, spannable.length(), 0);
- node.setContentDescription(spannable);
+ charSequence = spannable;
+ }
+ if (isEditableText) {
+ node.setText(charSequence);
+ node.setEditable(true);
} else {
- node.setContentDescription(contentDescription);
+ node.setContentDescription(charSequence);
}
}

Powered by Google App Engine
This is Rietveld 408576698